Fix SP initialize vs constructor differences #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SP behaves differently when constructor vs setters are used to set the same parameters!
this sets the num active columns, but also has to disable mutex localAreaDensity, according to the API it's done by = -1; but the setter wrongly used =0; fixed
also causes difference
this fixes the issue with different SP states when constructor/setter is used.
breznak
commented
Jan 19, 2018
| @@ -186,7 +186,7 @@ UInt SpatialPooler::getPotentialRadius() const | |||
|
|
|||
| void SpatialPooler::setPotentialRadius(UInt potentialRadius) | |||
| { | |||
| potentialRadius_ = potentialRadius; | |||
| potentialRadius_ = std::min(potentialRadius, numInputs_); //crop to numInputs (input size) | |||
There was a problem hiding this comment.
this caused the difference, because constructor does implicitly crop to bounds, while setter didn't.
TODO: do implicitly, or throw NTA_ASSERT?
| @@ -196,6 +196,7 @@ Real SpatialPooler::getPotentialPct() const | |||
|
|
|||
| void SpatialPooler::setPotentialPct(Real potentialPct) | |||
| { | |||
| NTA_ASSERT(potentialPct > 0 && potentialPct <= 1); //bounds check | |||
There was a problem hiding this comment.
turn assert to always check?
We should check the public API and if it's public, always check. Other hand, performance impact.
| @@ -219,7 +220,7 @@ void SpatialPooler::setNumActiveColumnsPerInhArea( | |||
| { | |||
| NTA_ASSERT(numActiveColumnsPerInhArea > 0); | |||
| numActiveColumnsPerInhArea_ = numActiveColumnsPerInhArea; | |||
| localAreaDensity_ = 0; | |||
| localAreaDensity_ = -1; //disabling | |||
There was a problem hiding this comment.
fixes the incompatibility with API documentation
2 tasks
breznak
added
code
|
@dkeeney please have a look, small PR, fixes a discrepancy in the API. Pls give your thoughts on the question: crop vs assert. |
|
Test configs need to be updated! |
dkeeney
previously approved these changes
Sep 3, 2018
breznak
pushed a commit
that referenced
this pull request
Dec 17, 2018
Connections fix bindings py change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SP behaves differently when constructor vs setters are used to set the
same parameters!
Fixes SpatialPooler initialization with constructor vs initialize() results in different SP state numenta/nupic.core-legacy#1386
Moved from SP: add test for different constructor vs setter behavior numenta/nupic.core-legacy#1387