This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
SP: add test for different constructor vs setter behavior #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SP behaves differently when constructor vs setters are used to set the same parameters!
breznak
commented
Jan 12, 2018
| sp.setPotentialPct(0.5); | ||
| sp.setGlobalInhibition(false); | ||
| sp.setLocalAreaDensity(0.02); //2% active cols | ||
| sp.setNumActiveColumnsPerInhArea(0); //mutex with above ^^ |
There was a problem hiding this comment.
I suspect an issue in these 2 values, which are mutually exclusive. the Num Active Cols per Inh Area should never be zero
this sets the num active columns, but also has to disable mutex localAreaDensity, according to the API it's done by = -1; but the setter wrongly used =0; fixed
also causes difference
this fixes the issue with different SP states when constructor/setter is used.
breznak
commented
Jan 12, 2018
| @@ -186,7 +186,7 @@ UInt SpatialPooler::getPotentialRadius() const | |||
|
|
|||
| void SpatialPooler::setPotentialRadius(UInt potentialRadius) | |||
| { | |||
| potentialRadius_ = potentialRadius; | |||
| potentialRadius_ = std::min(potentialRadius, numInputs_); //crop to numInputs (input size) | |||
There was a problem hiding this comment.
this caused the difference, because constructor does implicitly crop to bounds, while setter didn't.
TODO: do implicitly, or throw NTA_ASSERT?
| @@ -196,6 +196,7 @@ Real SpatialPooler::getPotentialPct() const | |||
|
|
|||
| void SpatialPooler::setPotentialPct(Real potentialPct) | |||
| { | |||
| NTA_ASSERT(potentialPct > 0 && potentialPct <= 1); //bounds check | |||
There was a problem hiding this comment.
turn assert to always check?
| @@ -219,7 +220,7 @@ void SpatialPooler::setNumActiveColumnsPerInhArea( | |||
| { | |||
| NTA_ASSERT(numActiveColumnsPerInhArea > 0); | |||
| numActiveColumnsPerInhArea_ = numActiveColumnsPerInhArea; | |||
| localAreaDensity_ = 0; | |||
| localAreaDensity_ = -1; //disabling | |||
There was a problem hiding this comment.
fixes incompatibility with API documentation
|
@rhyolight atomic and well tested PR, can we please review and merge asap? other PRs are blocked by this. |
This was referenced Jan 12, 2018
|
Closing for freeze of this repo, moved to htm-community#5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SP behaves differently when constructor vs setters are used to set the
same parameters!
Fixes #1386