-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring tide to root, and allow cargo run --example
#247
Conversation
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Awesome! I do think this is much nicer, and also keeps things consistent with But yeah, we can take the new path and figure things out as we go :) |
This approach is neat, reminds me of the way actix-web is laid out (with the main crate at root, so we no longer rely on a workspace manifest alone). I like it 👍 PS: Thanks for fixing my example! |
`tide` now sits at root of crate
If the travis bit can be fixed, I think we can merge this and handle the example clippy warnings post merge, for this particular instance. |
@prasannavl Yup, after these Travis runs finish, clippy should only be yelling at the examples (and we can just get those fixed up in a later PR) |
Clippy freaks out on the examples, but as mentioned before we can fix it later -- merging! |
`examples` is no longer a package in the workspace following #247
Description
Moves the tide submodule to the root of the crate, allows running examples using:
Also makes the examples to be run standalone without a need for
lib.rs
. Ref #223.Motivation and Context
This patch is an alternative to #227. As explained in #223 (comment), I think it's preferable if we keep Cargo's default behavior of being able to run examples using
cargo run --example
.I spent some time today trying to figure out how to run our examples, only to find out that they weren't runnable, which was unexpected, and admittedly rather frustrating.
How Has This Been Tested?
Types of changes
Checklist: