Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] trl doc build #416

Merged
merged 1 commit into from
Sep 27, 2023
Merged

[Fix] trl doc build #416

merged 1 commit into from
Sep 27, 2023

Conversation

mishig25
Copy link
Contributor

@mishig25 mishig25 commented Sep 27, 2023

Problem

Page https://huggingface.co/docs/trl/v0.7.1/en/ddpo_trainer was failing with:

node:internal/event_target:1083
  process.nextTick(() => { throw err; });
                           ^
Error: 500 /docs/trl/main/en/ddpo_trainer

Solution

Setting sveltekit.prerender.handleHttpError option from fail to warn solves the issue. Need a better fix. I'm not exactly sure why this error is happening at the moment. Tested the new builds locally to make sure of correctness.

image

@mishig25 mishig25 merged commit 58296fb into main Sep 27, 2023
4 checks passed
@mishig25 mishig25 deleted the handleHttpError_warn branch September 27, 2023 10:08
@mishig25
Copy link
Contributor Author

Although https://huggingface.co/docs/trl/main/en/ddpo_trainer built fine with 500 http error, other pages such as https://huggingface.co/docs/text-generation-inference/basic_tutorials/launcher is giving 404. Therefore, I'm gonna revert this change and work on better solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant