Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] parsing html node ending correctly #419

Merged
merged 1 commit into from
Sep 28, 2023
Merged

[Fix] parsing html node ending correctly #419

merged 1 commit into from
Sep 28, 2023

Conversation

mishig25
Copy link
Contributor

@mishig25 mishig25 commented Sep 28, 2023

This PR:

  1. Reverts changes in [Fix] trl doc build #416. As written in the comment here, my initial assumption of sveltekit http error 500 being not critical was wrong
  2. Escape HTML heading node correctly
<h3 id="id">My heading</h3>
Some markdown paragraph

get interpreted as one big html node by marked (see AST here). We would need space between them (see here).
Below is how it should look like

<h3 id="id">My heading</h3>

Some markdown paragraph

cc: @Wauplin

@mishig25 mishig25 changed the title [Fix] parsing html ending node correctly [Fix] parsing html node ending correctly Sep 28, 2023
@mishig25 mishig25 merged commit 7884a9e into main Sep 28, 2023
5 checks passed
@mishig25 mishig25 deleted the more_escaping_3 branch September 28, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant