Refactor the GeneratesTableOfContents internals to be more accurate #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
added
the
run-visual-tests
Preserves BC and is the intended behaviour
caendesilva
force-pushed
the
fix-setext-sidebar-table-of-contents-bug
branch
from
f008d99 to
95376fd
Compare
Codecov Report
@@ Coverage Diff @@
## master #1343 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1332 2668 +1336
=============================================
Files 152 304 +152
Lines 3474 6960 +3486
=============================================
+ Hits 3474 6960 +3486
... and 152 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
caendesilva
removed
the
run-visual-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the start marker with a placeholder, shifting the list in the temporary HTML to the bottom if the document, making it easier and less "hacky" to extract out. Actual returned result is unaffected, with the exception that Setext headers are now supported, fixing #1337.