Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publications refactors #1370

Merged
merged 29 commits into from
May 7, 2023
Merged

Conversation

caendesilva
Copy link
Member

No description provided.

Makes the PublicationPage::$type property readonly as it can't be persisted like that

There is no logic to change the type through the object, and I don't think there should be as it would add a considerable amount of complexity compared to the user just moving the file. Making it readonly makes it clear that it cannot be changed as changing the property would do nothing.
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #1370 (4aa9a2e) into publications-feature (94c4782) will not change coverage.
The diff coverage is n/a.

❗ Current head 4aa9a2e differs from pull request most recent head a075e9e. Consider uploading reports for the commit a075e9e to get more accurate results

@@                    Coverage Diff                    @@
##             publications-feature    #1370     +/-   ##
=========================================================
  Coverage                   99.97%   99.97%             
+ Complexity                   3394     1694   -1700     
=========================================================
  Files                         360      180    -180     
  Lines                        9170     4586   -4584     
=========================================================
- Hits                         9168     4585   -4583     
+ Misses                          2        1      -1     

see 183 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the publications-refactors branch from cd77321 to 59bceee Compare April 24, 2023 17:34
This just makes it all clearer. If/when we add more meta fields, that's something we can revisit then.
@caendesilva caendesilva force-pushed the publications-refactors branch from b5e91f6 to 7f4718c Compare April 24, 2023 18:20
@caendesilva caendesilva force-pushed the publications-refactors branch from 69b73f9 to eb02163 Compare April 25, 2023 08:16
@caendesilva caendesilva force-pushed the publications-refactors branch from 35fc0d9 to b626aad Compare April 25, 2023 09:12
@caendesilva caendesilva marked this pull request as ready for review May 7, 2023 19:13
@caendesilva caendesilva merged commit 4a7a221 into publications-feature May 7, 2023
@caendesilva caendesilva deleted the publications-refactors branch May 7, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant