Code

Publications refactors#1370

Code

Merged

caendesilva merged 29 commits intopublications-featurehydephp/develop:publications-featurefrom publications-refactorshydephp/develop:publications-refactorsCopy head branch name to clipboardMay 7, 2023

+42-48

Commits

Commits on Apr 24, 2023

• Replace ternary expression with coalesce assignment

  caendesilva

  committed
  1fbd2f8

• Fix experimental comment

  caendesilva

  committed
  054e77c

• Remove fixme as base classes have public properties

  caendesilva

  committed
  31ea952

• Make PublicationPage::$type readonly as it can't be persisted

  Show description for 9f8b3a4
  caendesilva

  committed
  9f8b3a4

• Move up parent constructor call

  caendesilva

  committed
  756a549

• Inline simple helper method

  caendesilva

  committed
  916f792

• Uninitialize publication page template property

  caendesilva

  committed
  59bceee

• Check directly against meta field name as we only have one

  Show description for 7f4718c
  caendesilva

  committed
  7f4718c

• Collect array in constructor instead of repeatedly in helper method

  Show description for 773c6a2
  caendesilva

  committed
  773c6a2

Commits on Apr 25, 2023

• Rename helper method only used once to be specific to that usage

  caendesilva

  committed
  9a38ed4

• Temporarily move up helper method in file

  caendesilva

  committed
  b2d97d2

• Inline helper method parameter value

  caendesilva

  committed
  eb02163

• Inline helper method parameter value

  caendesilva

  committed
  bf99a8d

• Move down todo

  caendesilva

  committed
  5d90636

• Split sprintf call to local variable

  caendesilva

  committed
  d2a3af9

• Make error message more fluent

  caendesilva

  committed
  b626aad

• Display field name

  caendesilva

  committed
  ccb045f

• Revert "Display field name"

  Show description for a3ae6c9
  caendesilva

  committed
  a3ae6c9

• Collect media files in root media directory

  caendesilva

  committed
  02d0a90

• Unwrap 'else'

  caendesilva

  committed
  4aa9a2e

• Put confirmation in if statement

  caendesilva

  committed
  5a464c5

• Ask user to select what to do next

  caendesilva

  committed
  905462e

• Remove todo for asking to select from root directory

  Show description for 3a68461
  caendesilva

  committed
  3a68461

• Revert "Ask user to select what to do next"

  Show description for f4a12ad
  caendesilva

  committed
  f4a12ad

• Revert "Put confirmation in if statement"

  Show description for b5929e8
  caendesilva

  committed
  b5929e8

• Revert "Unwrap 'else'"

  Show description for e7aafad
  caendesilva

  committed
  e7aafad

• Revert "Collect media files in root media directory"

  Show description for 46d635c
  caendesilva

  committed
  46d635c

• Add new todo

  caendesilva

  committed
  d7556ff

• Inline local variable

  caendesilva

  committed
  a075e9e