Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor colored blockquote internals to extract class name from signature #1413

Merged
merged 8 commits into from
Oct 29, 2023

Conversation

caendesilva
Copy link
Member

Refactors the internal class to extract blockquote class names from the signature, instead of creating new anonymous classes. This is not breaking, as the class was marked internal for this very reason before the first stable release.

@caendesilva caendesilva force-pushed the refactor-colored-blockquote-internals branch from c0781cf to d818c59 Compare October 29, 2023 09:35
@caendesilva caendesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #1413 (4af3c81) into master (285f819) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4af3c81 differs from pull request most recent head e90de61. Consider uploading reports for the commit e90de61 to get more accurate results

@@              Coverage Diff              @@
##              master     #1413     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1703      3412   +1709     
=============================================
  Files            180       360    +180     
  Lines           4628      9242   +4614     
=============================================
+ Hits            4628      9242   +4614     
Files Coverage Δ
...ork/src/Markdown/Processing/ColoredBlockquotes.php 100.00% <100.00%> (ø)
...ork/src/Markdown/Processing/ShortcodeProcessor.php 100.00% <100.00%> (ø)

... and 180 files with indirect coverage changes

@caendesilva caendesilva removed the run-visual-tests Internal label to trigger Browserstack visual testing label Oct 29, 2023
@caendesilva caendesilva merged commit 0108b87 into master Oct 29, 2023
13 checks passed
@caendesilva caendesilva deleted the refactor-colored-blockquote-internals branch October 29, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant