Feat/image loading errors #858
Conversation
bitbeckers
commented
Jun 20, 2023
bitbeckers
commented
- Added 400 error to CORS when URL missing
- Added catch to html2canvas async call
- Error loggin and toast
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -516,7 +522,18 @@ const exportAsImage = async (id: string) => { | |||
| //useCORS: true, | |||
| proxy: "https://cors-proxy.hypercerts.workers.dev/", | |||
| imageTimeout: 0, | |||
| }).catch((e) => { | |||
There was a problem hiding this comment.
Are we sure that html2canvas will throw an error if fetching the image fails? Worth some testing either manually or via unit/integration tests.
There was a problem hiding this comment.
Actually now that I think about it, I don't think this solves the issue, because without the catch any thrown errors should stop everything. Instead the behavior we see is that the hypercert mints anyway with the broken images.
So catching is insufficient....
There was a problem hiding this comment.
Yep found the same during testing rn. I'm going to think about an alternative route. Because it's not like the canvas will be empty (that'd be easy to check), it's missing one specific layer
| }); | ||
|
|
||
| if (!canvas) { | ||
| return undefined; |
There was a problem hiding this comment.
Probably should show an error message?
|
Moving this PR to #1145 as this has become stale. |
|
@holkeb have you heard anything about this? |
|
Moving to backlog until further notice, as no requests or messages relating to this issue came to our attention since work was commenced on this. |
