Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/image loading errors #858

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feat/image loading errors #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd6b1e7
fix(cors): 400 res on missing url
bitbeckers Jun 20, 2023
ee89e21
feat(canvas): error handling and toast
bitbeckers Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cors-proxy/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@ export default {
const apiUrl = url.searchParams.get(QUERYSTRING_KEY);

if (apiUrl == null) {
return new Response(`Missing GET parameter: ${QUERYSTRING_KEY}`);
return new Response(`Missing GET parameter: ${QUERYSTRING_KEY}`, {
status: 400,
statusText: `Bad Request: ${QUERYSTRING_KEY} param undefined`,
});
}

// Rewrite request to point to API URL. This also makes the request mutable
Expand Down
17 changes: 17 additions & 0 deletions frontend/components/hypercert-create.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,12 @@ export function HypercertCreateForm(props: HypercertCreateFormProps) {
}

const image = await exportAsImage(IMAGE_SELECTOR);

if (!image) {
setSubmitting(false);
return;
}

const metaData = formatValuesToMetaData(
values,
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
Expand Down Expand Up @@ -516,7 +522,18 @@ const exportAsImage = async (id: string) => {
//useCORS: true,
proxy: "https://cors-proxy.hypercerts.workers.dev/",
imageTimeout: 0,
}).catch((e) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that html2canvas will throw an error if fetching the image fails? Worth some testing either manually or via unit/integration tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually now that I think about it, I don't think this solves the issue, because without the catch any thrown errors should stop everything. Instead the behavior we see is that the hypercert mints anyway with the broken images.

So catching is insufficient....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep found the same during testing rn. I'm going to think about an alternative route. Because it's not like the canvas will be empty (that'd be easy to check), it's missing one specific layer

toast("Error loading hypercert image . Please contact the team.", {
type: "error",
});
console.error("Error exporting image: ", e);
return undefined;
});

if (!canvas) {
return undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should show an error message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

}

const image = canvas.toDataURL("image/png", 1.0);
return image;
};