Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(github): stop using NodeJS v16 based actions due to deprecation #3079

Closed
petermetz opened this issue Mar 11, 2024 · 0 comments · Fixed by #3080
Closed

ci(github): stop using NodeJS v16 based actions due to deprecation #3079

petermetz opened this issue Mar 11, 2024 · 0 comments · Fixed by #3080
Assignees
@petermetz
Labels
dependencies Pull requests that update a dependency file Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Milestone
v2.0.0

Comments

@petermetz
Copy link
Contributor

Description

Warnings started popping up in the CI that look like this so a mass-upgrade of
CI tasks is to be performed:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20:
actions/setup-node@v3.6.0,
actions/checkout@v3.5.2,
actions/cache@v3.0.4.
For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Acceptance Criteria

  1. Tests are still passing
  2. The diff is as small as possible and surgical, no other changes just the CI action version upgrades
@petermetz petermetz added dependencies Pull requests that update a dependency file Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Tests Anything related to tests be that automatic or manual, integration or unit, etc. P3 Priority 3: Medium labels Mar 11, 2024
@petermetz petermetz added this to the v2.0.0 milestone Mar 11, 2024
@petermetz petermetz self-assigned this Mar 11, 2024
petermetz added a commit to petermetz/cacti that referenced this issue Mar 11, 2024
@petermetz
ci(github): stop using NodeJS v16 based actions due to deprecation
6126e6d 
No changes other than the mass find & replacing of the GitHub actions
that we use for setting up NodeJS, checking code out and caching.

Address the warnings that started popping up in the CI that look like
this, asking for a mass-upgrade of CI action versions:

> Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20:
> actions/setup-node@v4.0.2,
> actions/checkout@v4.1.1,
> actions/cache@v4.0.1
> For more information see:
> https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Fixes hyperledger-cacti#3079

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
This was referenced Mar 11, 2024
Closed
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Mar 13, 2024
@petermetz
ci(github): stop using NodeJS v16 based actions due to deprecation
c203bc9 
No changes other than the mass find & replacing of the GitHub actions
that we use for setting up NodeJS, checking code out and caching.

Address the warnings that started popping up in the CI that look like
this, asking for a mass-upgrade of CI action versions:

> Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20:
> actions/setup-node@v4.0.2,
> actions/checkout@v4.1.1,
> actions/cache@v4.0.1
> For more information see:
> https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Fixes hyperledger-cacti#3079

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Mar 13, 2024
@petermetz
ci(github): stop using NodeJS v16 based actions due to deprecation
dec0f3b 
No changes other than the mass find & replacing of the GitHub actions
that we use for setting up NodeJS, checking code out and caching.

Address the warnings that started popping up in the CI that look like
this, asking for a mass-upgrade of CI action versions:

> Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20:
> actions/setup-node@v4.0.2,
> actions/checkout@v4.1.1,
> actions/cache@v4.0.1
> For more information see:
> https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Fixes #3079

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Cacti_Scrum_Project_v2_Release Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
dependencies Pull requests that update a dependency file Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Milestone
v2.0.0
1 participant
@petermetz