Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core-api): move PluginRegistry to core package #380

Closed
petermetz opened this issue Nov 10, 2020 · 0 comments · Fixed by #402
Closed

refactor(core-api): move PluginRegistry to core package #380

petermetz opened this issue Nov 10, 2020 · 0 comments · Fixed by #402
Assignees
@petermetz
Labels
Nice-to-Have
Milestone
v0.3.0

Comments

@petermetz
Copy link
Contributor

Description

The core API package should refrain from having implementation code in it so that it stays as true as possible to the name "API" in the old Java parlance where you would have x-impl and x-api artifacts containing the implementation and the API definitions/interfaces respectively.

Acceptance Criteria

  1. PluginRegistry class moved from the cactus-core-api package to the cactus-core package.
  2. CI is passing.
  3. References in documentation are updated accordingly as well.

cc: @takeutak @sfuji822 @jonathan-m-hamilton
@petermetz petermetz added this to the v0.3.0 milestone Nov 10, 2020
@petermetz petermetz self-assigned this Dec 2, 2020
petermetz added a commit to petermetz/cacti that referenced this issue Dec 2, 2020
@petermetz
refactor(core-api): move PluginRegistry to core package
6c88f64 
Fixes hyperledger-cacti#380

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz linked a pull request Dec 2, 2020 that will close this issue
refactor(core-api): move PluginRegistry to core package #402
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Dec 2, 2020
@petermetz
refactor(core-api): move PluginRegistry to core package
f0878ea 
Resolves hyperledger-cacti#380

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 4, 2020
@petermetz
refactor(core-api): move PluginRegistry to core package
d8cd0f6 
Resolves hyperledger-cacti#380

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 11, 2020
@petermetz
refactor(core-api): move PluginRegistry to core package
762b64f 
Resolves hyperledger-cacti#380

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 14, 2020
@petermetz
refactor(core-api): move PluginRegistry to core package
33b33fd 
Resolves hyperledger-cacti#380

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 16, 2020
@petermetz
refactor(core-api): move PluginRegistry to core package
5f73b72 
Resolves hyperledger-cacti#380

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 16, 2020
@petermetz
refactor(core-api): move PluginRegistry to core package
c0b7e58 
Resolves hyperledger-cacti#380

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 16, 2020
@petermetz
refactor(core-api): move PluginRegistry to core package
46383b6 
Resolves hyperledger-cacti#380

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 16, 2020
@petermetz
refactor(core-api): move PluginRegistry to core package
c5365e2 
Resolves hyperledger-cacti#380

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 16, 2020
@petermetz
refactor(core-api): move PluginRegistry to core package
5c030ac 
Resolves hyperledger-cacti#380

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 16, 2020
@petermetz
refactor(core-api): move PluginRegistry to core package
dbd2846 
Resolves hyperledger-cacti#380

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Jan 4, 2021
@petermetz
refactor(core-api): move PluginRegistry to core package
eda00be 
Resolves #380

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
Nice-to-Have
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

refactor(core-api): move PluginRegistry to core package petermetz/cacti
1 participant
@petermetz