-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core-api): move PluginRegistry to core package #402
refactor(core-api): move PluginRegistry to core package #402
Conversation
6c88f64
to
f0878ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f0878ea
to
d8cd0f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The design of PluginRegistry depends to the architecture of Cactus, and this is now under the discussion in PR331,368. Therefore, please allow me to review this PR after PR331,368.
@takeutak I think we could optimize our review pipeline/development processes in general to be a little more efficient if we didn't make code changes dependent on documentation changes happening first. [1]: Production grade, enterprise ready, generic, flexible, pluggable blockchain integration framework with a healthy open source community around it. |
c5365e2
to
5c030ac
Compare
Resolves hyperledger-cacti#380 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
5c030ac
to
dbd2846
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Commit to be reviewed: