Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-api): move PluginRegistry to core package #402

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Dec 2, 2020

Commit to be reviewed:

commit 6c88f647baf6f5f70e47d2634697d47498e8bed4 (refactor/core-api/move-pluginregistry-to-core-package-380)
Author: Peter Somogyvari <peter.somogyvari@accenture.com>
Date:   Tue Dec 1 17:04:16 2020 -0800

    refactor(core-api): move PluginRegistry to core package
    
    Fixes #380
    
    Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>

@petermetz petermetz added this to the v0.3.0 milestone Dec 2, 2020
@petermetz petermetz linked an issue Dec 2, 2020 that may be closed by this pull request
@petermetz petermetz force-pushed the refactor/core-api/move-pluginregistry-to-core-package-380 branch from 6c88f64 to f0878ea Compare December 2, 2020 19:47
@petermetz petermetz removed this from the v0.3.0 milestone Dec 2, 2020
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz added this to the v0.3.0 milestone Dec 4, 2020
@petermetz petermetz force-pushed the refactor/core-api/move-pluginregistry-to-core-package-380 branch from f0878ea to d8cd0f6 Compare December 4, 2020 20:27
Copy link
Contributor

@takeutak takeutak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design of PluginRegistry depends to the architecture of Cactus, and this is now under the discussion in PR331,368. Therefore, please allow me to review this PR after PR331,368.

@petermetz
Copy link
Contributor Author

petermetz commented Dec 11, 2020

The design of PluginRegistry depends to the architecture of Cactus, and this is now under the discussion in PR331,368. Therefore, please allow me to review this PR after PR331,368.

@takeutak I think we could optimize our review pipeline/development processes in general to be a little more efficient if we didn't make code changes dependent on documentation changes happening first.
With the risk of crossing into philosophy from software engineering: This goes back to my belief that as much as design is important, we are building something that [1] we have never done before so it may be preferable to iterate fast and be willing to refactor often (while we still can, prior to the 1.0 launch) instead of attempting to get it right with up-front design that locks in the implementation. What do you think?

[1]: Production grade, enterprise ready, generic, flexible, pluggable blockchain integration framework with a healthy open source community around it.

Resolves hyperledger-cacti#380

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the refactor/core-api/move-pluginregistry-to-core-package-380 branch from 5c030ac to dbd2846 Compare December 16, 2020 21:47
@takeutak takeutak self-requested a review December 21, 2020 12:31
Copy link
Contributor

@takeutak takeutak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit eda00be into hyperledger-cacti:master Jan 4, 2021
@petermetz petermetz deleted the refactor/core-api/move-pluginregistry-to-core-package-380 branch January 4, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(core-api): move PluginRegistry to core package
3 participants