Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin-registry): get keychain by keychainId #381

Closed
petermetz opened this issue Nov 10, 2020 · 0 comments · Fixed by #382
Closed

feat(plugin-registry): get keychain by keychainId #381

petermetz opened this issue Nov 10, 2020 · 0 comments · Fixed by #382
Labels
enhancement New feature or request
Milestone
v0.3.0

Comments

@petermetz
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently when I want to locate a keychain plugin based on the keychain ID I have to type out the filtering logic myself and handle the sad path of the plugin not being in the registry as well.

Describe the solution you'd like

I want a utility method where I can just pass in the keychain ID and get back a plugin instance or an exception thrown if it was not found.

Describe alternatives you've considered

Considered having this utility method outside of the PluginRegistry class itself, but the method itself is definitely needed to reduce boilerplate code.

cc: @takeutak @sfuji822 @jonathan-m-hamilton
@petermetz petermetz added the enhancement New feature or request label Nov 10, 2020
@petermetz petermetz added this to the v0.3.0 milestone Nov 10, 2020
petermetz added a commit to petermetz/cacti that referenced this issue Nov 10, 2020
@petermetz
feat(plugin-registry): get keychain by keychainId
be42952 
Adds a utility method where I can just pass in the
keychain ID and get back a plugin instance or an
exception thrown if it was not found.

Fixes hyperledger-cacti#381

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
This was referenced Nov 10, 2020
Merged
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Nov 12, 2020
@petermetz
feat(plugin-registry): get keychain by keychainId
e17081c 
Adds a utility method where I can just pass in the
keychain ID and get back a plugin instance or an
exception thrown if it was not found.

Fixes hyperledger-cacti#381

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 1, 2020
@petermetz
feat(plugin-registry): get keychain by keychainId
c144a72 
Adds a utility method where I can just pass in the
keychain ID and get back a plugin instance or an
exception thrown if it was not found.

Fixes hyperledger-cacti#381

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 11, 2020
@petermetz
feat(plugin-registry): get keychain by keychainId
0f58457 
Adds a utility method where I can just pass in the
keychain ID and get back a plugin instance or an
exception thrown if it was not found.

Fixes hyperledger-cacti#381

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 11, 2020
@petermetz
feat(plugin-registry): get keychain by keychainId
3e4cc57 
Adds a utility method where I can just pass in the
keychain ID and get back a plugin instance or an
exception thrown if it was not found.

Fixes hyperledger-cacti#381

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 14, 2020
@petermetz
feat(plugin-registry): get keychain by keychainId
51cc217 
Adds a utility method where I can just pass in the
keychain ID and get back a plugin instance or an
exception thrown if it was not found.

Fixes hyperledger-cacti#381

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Dec 15, 2020
@petermetz
feat(plugin-registry): get keychain by keychainId
4d93c72 
Adds a utility method where I can just pass in the
keychain ID and get back a plugin instance or an
exception thrown if it was not found.

Fixes #381

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

feat(plugin registry): get keychain by keychain id petermetz/cacti
1 participant
@petermetz