Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin registry): get keychain by keychain id #382

Merged
merged 1 commit into from
Dec 15, 2020
Merged

feat(plugin registry): get keychain by keychain id #382

merged 1 commit into from
Dec 15, 2020

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Nov 10, 2020 •
edited
Loading

Commit to be reviewed:

feat(plugin-registry): get keychain by keychainId …
be42952
Adds a utility method where I can just pass in the
keychain ID and get back a plugin instance or an
exception thrown if it was not found.

Fixes #381

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>

Resolves #381

@petermetz petermetz added this to the v0.3.0 milestone Nov 10, 2020
@petermetz petermetz force-pushed the feat/plugin-registry/get-keychain-by-keychain-id-381 branch from be42952 to e17081c Compare November 12, 2020 20:55
jonathan-m-hamilton
jonathan-m-hamilton approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz force-pushed the feat/plugin-registry/get-keychain-by-keychain-id-381 branch from e17081c to c144a72 Compare December 1, 2020 16:59
@petermetz petermetz modified the milestone: v0.3.0 Dec 2, 2020
takeutak
takeutak reviewed Dec 11, 2020
View reviewed changes
Copy link
Contributor

@takeutak takeutak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design of KeyChainID relates to the architecture of Cactus, and this is under discussion in PR #331, #368. Therefore, please allow me to review this PR after PR #331, #368.

@petermetz
Copy link
Contributor Author

The design of KeyChainID relates to the architecture of Cactus

@takeutak This pull request does not propose any changes to the design of the keychain ID. It's about a utility function aimed to provide developer convenience. Do you think we still need to wait for those whitepaper changes to go through before you can review this?

@petermetz petermetz force-pushed the feat/plugin-registry/get-keychain-by-keychain-id-381 branch from c144a72 to 0f58457 Compare December 11, 2020 20:50
@petermetz
feat(plugin-registry): get keychain by keychainId
51cc217 
Adds a utility method where I can just pass in the
keychain ID and get back a plugin instance or an
exception thrown if it was not found.

Fixes hyperledger-cacti#381

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the feat/plugin-registry/get-keychain-by-keychain-id-381 branch from 0f58457 to 51cc217 Compare December 14, 2020 18:27
takeutak
takeutak approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@takeutak takeutak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit 4d93c72 into hyperledger-cacti:master Dec 15, 2020
@petermetz petermetz deleted the feat/plugin-registry/get-keychain-by-keychain-id-381 branch December 15, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takeutak takeutak takeutak approved these changes

@jonathan-m-hamilton jonathan-m-hamilton jonathan-m-hamilton approved these changes

@sfuji822 sfuji822 Awaiting requested review from sfuji822

Assignees
No one assigned
Labels
Nice-to-Have
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

feat(plugin-registry): get keychain by keychainId
3 participants
@petermetz @jonathan-m-hamilton @takeutak