-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(validator): Indy validator and indy-testnet files #1099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@izuru0 Thank you for the contribution! Could you add a remote adapter for this in Typescript so that the API server can pull it in as a plugin as well?
@petermetz Thank you for your comment. It is nice to have interoperability between API server and connector (possibly not just for Indy but other ledgers too). I think we can design a wrapper to make indy validator (in python) to be callable, but I suspect that it could take some time to design a standard interface between API server in typescript and (arbitrary) connector in python. For that reason, can I ask this code to be accepted for the time being, and consider the designing/implementing such interface as other task? |
@izuru0 Sure thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@izuru0 Please squash into a single commit, then it LGTM.
Let me know if you need help with the git mechanics, happy to help.
@izuru0 It seems that he created a new pull request #1117 having the same codes instead of squashing. So I think it is no problem to close this PR #1099. Is it OK? @petermetz So would you mind if you review the new PR #1117 again? |
@takeutak @izuru0 Any chance that you could just do the squash instead of me reviewing the entire PR again? It takes 30 seconds to squash, if you don't know how to do it I can help. |
6df86ef
to
7002c98
Compare
Signed-off-by: Izuru Sato <sato.izuru@fujitsu.com>
7002c98
to
f0c60ee
Compare
Codecov Report
@@ Coverage Diff @@
## main #1099 +/- ##
=======================================
Coverage 73.14% 73.14%
=======================================
Files 246 246
Lines 8617 8617
Branches 996 996
=======================================
Hits 6303 6303
Misses 1783 1783
Partials 531 531 Continue to review full report at Codecov.
|
Added new code that talks to indy pool. It submits request to indy it received and sends response back.
The python code will be updated in the future so that users can simply pip install them and run (although it is incomplete at the moment). The directory structure reflects this intention.
Also included are updated version of indy-testnet files. The code described above needs this environment to properly run.