Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validator): Indy validator and indy-testnet files #1117

Closed
wants to merge 1 commit into from

Conversation

izuru0
Copy link
Contributor

@izuru0 izuru0 commented Jul 9, 2021

This is a resubmission of #1099.
(reason: there were multiple commits in #1099)

Added new code that talks to indy pool. It submits request to indy it received and sends response back.
The python code will be updated in the future so that users can simply pip install them and run (although it is incomplete at the moment). The directory structure reflects this intention.

Also included are updated version of indy-testnet files. The code described above needs this environment to properly run.

Signed-off-by: Izuru Sato sato.izuru@fujitsu.com

Signed-off-by: Izuru Sato <sato.izuru@fujitsu.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1117 (8c991da) into main (c037ec5) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 8c991da differs from pull request most recent head 21b46ce. Consider uploading reports for the commit 21b46ce to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1117      +/-   ##
==========================================
- Coverage   73.05%   73.03%   -0.02%     
==========================================
  Files         244      244              
  Lines        8557     8557              
  Branches      991      991              
==========================================
- Hits         6251     6250       -1     
- Misses       1778     1779       +1     
  Partials      528      528              
Impacted Files Coverage Δ
...main/typescript/rustc-container/rustc-container.ts 66.29% <0.00%> (-2.25%) ⬇️
...t-tooling/src/main/typescript/common/containers.ts 74.89% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c037ec5...21b46ce. Read the comment docs.

@takeutak
Copy link
Contributor

@petermetz Would you mind if you approve this PR because this PR has the same codes as the old PR #1099. He seems to create this PR instead of solving GitHub errors on #1099.

@petermetz
Copy link
Contributor

@petermetz Would you mind if you approve this PR because this PR has the same codes as the old PR #1099. He seems to create this PR instead of solving GitHub errors on #1099.

@takeutak Please see #1099 (comment)

@izuru0 I'm available for a pair programming session today or tomorrow if you need help with git squashing, also feel free to ping me on here or RocketChat.

@takeutak
Copy link
Contributor

@izuru0 This PR is closed since the PR #1099 was merged.

@takeutak takeutak closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants