Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce noise in logs #2581

Closed
appetrosyan opened this issue Aug 2, 2022 · 0 comments
Closed

Reduce noise in logs #2581

appetrosyan opened this issue Aug 2, 2022 · 0 comments
Assignees
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@appetrosyan
Copy link
Contributor

appetrosyan commented Aug 2, 2022

In a real deployment it is almost impossible to combine health-checks and actual log investigation, because warp produces logs regardless of whether or not they're useful.

image.png
In this example, we have two lines taken up by what is effectively noise.

At a minimum we should be able to reduce the log level of warp independently.

The default should be set to DEBUG or better TRACE as the information is effectively a filter trace, which isn't particularly useful at our stage of development, but might be useful for debugging purposes.

@appetrosyan appetrosyan added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Aug 2, 2022
@appetrosyan appetrosyan self-assigned this Aug 4, 2022
@SamHSmith SamHSmith assigned SamHSmith and unassigned SamHSmith Dec 15, 2022
0x009922 added a commit to 0x009922/iroha that referenced this issue Mar 30, 2023
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
0x009922 added a commit that referenced this issue Mar 31, 2023
* [fix]: fix `WasmSmartContract` debug representation

It used to print ALL its bytes instead of
a formatted short form

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>

* [fix] #2581: exclude `/health` endpoint from tracing

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>

---------

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
appetrosyan pushed a commit that referenced this issue Jun 5, 2023
* [fix]: fix `WasmSmartContract` debug representation

It used to print ALL its bytes instead of
a formatted short form

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>

* [fix] #2581: exclude `/health` endpoint from tracing

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>

---------

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
mversic pushed a commit that referenced this issue Oct 17, 2023
* [fix]: fix `WasmSmartContract` debug representation

It used to print ALL its bytes instead of
a formatted short form

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>

* [fix] #2581: exclude `/health` endpoint from tracing

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>

---------

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

3 participants