-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] #2581: reduce noise in logs #3340
Merged
0x009922
merged 2 commits into
hyperledger-iroha:iroha2-dev
from
0x009922:2581-reduce-logs-noise
Mar 31, 2023
Merged
[fix] #2581: reduce noise in logs #3340
0x009922
merged 2 commits into
hyperledger-iroha:iroha2-dev
from
0x009922:2581-reduce-logs-noise
Mar 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to print ALL its bytes instead of a formatted short form Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
0x009922
requested review from
s8sato,
appetrosyan,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev and
Erigara
as code owners
March 30, 2023 13:26
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Mar 30, 2023
mversic
reviewed
Mar 30, 2023
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #3340 +/- ##
==============================================
- Coverage 62.33% 57.68% -4.65%
==============================================
Files 169 162 -7
Lines 31218 31914 +696
==============================================
- Hits 19459 18409 -1050
- Misses 11759 13505 +1746
... and 26 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mversic
approved these changes
Mar 30, 2023
appetrosyan
approved these changes
Mar 30, 2023
5 tasks
appetrosyan
pushed a commit
that referenced
this pull request
Jun 5, 2023
* [fix]: fix `WasmSmartContract` debug representation It used to print ALL its bytes instead of a formatted short form Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [fix] #2581: exclude `/health` endpoint from tracing Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> --------- Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
mversic
pushed a commit
that referenced
this pull request
Oct 17, 2023
* [fix]: fix `WasmSmartContract` debug representation It used to print ALL its bytes instead of a formatted short form Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [fix] #2581: exclude `/health` endpoint from tracing Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> --------- Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've researched for possible ways on how to configure logging in
warp
. I found that it's not easy.Provided warp's tracing filter has hard-coded log levels. To implement something similar, but with patched levels, we need to implement
Filter
. This is not possible because library authors decided that this should be kept internally and consumers should build their filters in a "convenient" way withwarp::any()
.So, we decided to exclude
/health
route from logging at all, as this is the primary issue.Also, I found that
WasmSmartContract
debug repr was not that is expected, and fixed it.Linked issue
Closes #2581
Benefits
Checklist
CONTRIBUTING.md