Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] #4075: Move metrics related functionality into MetricsReporter #4379

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Mar 21, 2024

Description

  • sumergai no longer responsible for handling metrics for torii
  • fix bug with not proper view change index in metrics

Linked issue

Closes #4075

@Erigara Erigara added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels Mar 21, 2024
@Erigara Erigara self-assigned this Mar 21, 2024
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Mar 21, 2024
@mversic mversic changed the title [refactor]: Move metrics related functionality into MetricsReporter [refactor] #4075: Move metrics related functionality into MetricsReporter Mar 21, 2024
mversic
mversic previously approved these changes Mar 22, 2024
@Erigara Erigara removed the api-changes Changes in the API for client libraries label Mar 22, 2024
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Mar 28, 2024
mversic
mversic previously approved these changes Mar 28, 2024
@coveralls
Copy link

coveralls commented Mar 28, 2024

Pull Request Test Coverage Report for Build 8478813624

Details

  • 0 of 136 (0.0%) changed or added relevant lines in 4 files are covered.
  • 5284 unchanged lines in 95 files lost coverage.
  • Overall coverage increased (+0.8%) to 57.549%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/sumeragi/mod.rs 0 9 0.0%
torii/src/routing.rs 0 9 0.0%
torii/src/lib.rs 0 16 0.0%
core/src/metrics.rs 0 102 0.0%
Files with Coverage Reduction New Missed Lines %
primitives/src/conststr.rs 1 91.14%
crypto/src/hash.rs 1 73.78%
ffi/derive/src/convert.rs 1 84.45%
primitives/src/lib.rs 1 0.0%
core/src/sumeragi/network_topology.rs 1 98.78%
primitives/src/must_use.rs 2 74.29%
crypto/src/signature/bls/mod.rs 2 0.0%
config/src/snapshot.rs 3 78.57%
data_model/derive/src/has_origin.rs 3 95.16%
config/src/kura.rs 3 80.0%
Totals Coverage Status
Change from base Build 7884695009: 0.8%
Covered Lines: 23358
Relevant Lines: 40588

💛 - Coveralls

0x009922
0x009922 previously approved these changes Apr 11, 2024
core/src/metrics.rs Outdated Show resolved Hide resolved
core/src/metrics.rs Outdated Show resolved Hide resolved
@Erigara Erigara dismissed stale reviews from 0x009922 and mversic via 971dbb1 April 15, 2024 08:35
0x009922
0x009922 previously approved these changes Apr 16, 2024
@nxsaken nxsaken changed the base branch from iroha2-dev to main April 16, 2024 08:33
@nxsaken nxsaken dismissed 0x009922’s stale review April 16, 2024 08:33

The base branch was changed.

Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara removed the api-changes Changes in the API for client libraries label Apr 19, 2024
@Erigara Erigara merged commit fa03b1a into hyperledger-iroha:main Apr 19, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor]: Move metrics into separate service
4 participants