-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] #4075: Move metrics related functionality into MetricsReporter #4379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
added
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Refactor
Improvement to overall code quality
labels
Mar 21, 2024
Erigara
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
outoftardis,
0x009922,
DCNick3,
VAmuzing and
Asem-Abdelhady
as code owners
March 21, 2024 14:09
mversic
changed the title
[refactor]: Move metrics related functionality into MetricsReporter
[refactor] #4075: Move metrics related functionality into MetricsReporter
Mar 21, 2024
mversic
reviewed
Mar 22, 2024
mversic
previously approved these changes
Mar 22, 2024
Erigara
force-pushed
the
metrics_reporter
branch
from
March 28, 2024 09:02
b9fc355
to
e8f7626
Compare
mversic
previously approved these changes
Mar 28, 2024
Pull Request Test Coverage Report for Build 8478813624Details
💛 - Coveralls |
mversic
force-pushed
the
metrics_reporter
branch
from
March 29, 2024 08:13
e8f7626
to
b986497
Compare
Erigara
force-pushed
the
metrics_reporter
branch
from
April 8, 2024 07:49
b986497
to
8819cad
Compare
0x009922
previously approved these changes
Apr 11, 2024
0x009922
reviewed
Apr 11, 2024
Erigara
force-pushed
the
metrics_reporter
branch
from
April 15, 2024 08:35
8819cad
to
971dbb1
Compare
Erigara
force-pushed
the
metrics_reporter
branch
from
April 15, 2024 08:58
971dbb1
to
7bd6b9d
Compare
0x009922
previously approved these changes
Apr 16, 2024
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
force-pushed
the
metrics_reporter
branch
from
April 19, 2024 08:20
7bd6b9d
to
f18d437
Compare
0x009922
approved these changes
Apr 19, 2024
mversic
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Refactor
Improvement to overall code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue
Closes #4075