refactor(view_change): only send current and previous view change proof #4929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
added
Refactor
Erigara
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
0x009922,
DCNick3 and
dima74
as code owners
Erigara
force-pushed
the
optimize_view_chage_update
branch
2 times, most recently
from
63556e6
to
caef8df
Compare
mversic
force-pushed
the
optimize_view_chage_update
branch
2 times, most recently
from
d9414ba
to
b518b78
Compare
mversic
force-pushed
the
optimize_view_chage_update
branch
from
b518b78
to
2e9799a
Compare
Erigara
force-pushed
the
optimize_view_chage_update
branch
from
2e9799a
to
8c086c6
Compare
mversic
force-pushed
the
optimize_view_chage_update
branch
from
8c086c6
to
b663326
Compare
Erigara
force-pushed
the
optimize_view_chage_update
branch
from
b663326
to
85aee61
Compare
mversic
force-pushed
the
optimize_view_chage_update
branch
3 times, most recently
from
685ed4d
to
1e9f768
Compare
mversic
requested changes
Sep 5, 2024
mversic
force-pushed
the
optimize_view_chage_update
branch
from
1e9f768
to
a193515
Compare
mversic
approved these changes
Sep 5, 2024
mversic
force-pushed
the
optimize_view_chage_update
branch
from
a193515
to
69465df
Compare
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic
force-pushed
the
optimize_view_chage_update
branch
from
69465df
to
dcb45ab
Compare
SamHSmith
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of sending every view change proof only view change proof for current round and previous verified proof are sent.
Linked issue
Closes #4926
Benefits
This help peer which is lagging behind to directly jump to most recent view change and participate in consensus.