-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sumeragi): dynamic commit time based on view change index #4957
Conversation
6e8d9ff
to
f9b4271
Compare
f9b4271
to
e105222
Compare
e105222
to
e63df38
Compare
e63df38
to
42d3276
Compare
this will increase |
Added |
42d3276
to
193c3a1
Compare
I approve that the growth is linear with |
let's merge this and split that discussion into a separate ticket |
193c3a1
to
43dfeeb
Compare
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
43dfeeb
to
220ef08
Compare
Description
Note: #4929 would also nice to have because it prevents degradation of view change updates.
Linked issue
Closes #4265
Benefits
This allow to consensus to pass heavy transactions which cause infinite loop previously.
How to test?
Currently it's not possible to modulary test consensus :(
So i've did my tests on bare metal iroha with 4 nodes.
Parameters:
config.toml:
genesis.json:
Notice that
transaction_gossip_period_ms
was crucial here, because without it i faced #4952.Check this comment for the transaction i've submitted to iroha.