-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js): update ffi-napi #331
Conversation
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Any idea on the failed test? Looks unrelated to what you did, but... |
It seems that it already failed on the last commit, around 45 days ago: https://github.com/hyperledger/anoncreds-rs/actions/runs/8031489343/job/21939863984 If we look at the latest successful AnonCreds Lint action, we'll find that it was installing a different rustc version:
This happens because in the CI we are setting @andrewwhitehead @berendsliedrecht do you think we can stick to 1.71? Or do you find better to see why this format check is failing with 1.73 and fix it? |
@@ -27,7 +27,7 @@ | |||
"install": "node scripts/install.js" | |||
}, | |||
"dependencies": { | |||
"@2060.io/ffi-napi": "4.0.8", | |||
"@2060.io/ffi-napi": "4.0.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should use caret versions so we can publish fixes to the ffi-napi in the future without having to make new releases for the wrappers
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Updated
ffi-napi
dependency on JS wrapper in order to fix the incompatibility issue found with newer node.js versions. See nodejs/node#52240 (comment).