The latest minor version update broke ffi-napi compatibility

[lingyuj]

The widely used ffi-napi module won't build with the latest minor update across almost all version.
It can build with ~ 20.11.1, ~ 21.5.0
But failed with 20.12.0, 21.6.0 ~

The error log is :
npm ERR! /home/mark/Projects/eudiw-app/node_modules/node-addon-api/napi-inl.h:63:47: error: invalid conversion from ‘napi_finalize’ {aka ‘void ()(napi_env__, void*, void*)’} to ‘node_api_nogc_finalize’ {aka ‘void ()(const napi_env__, void*, void*)’} [-fpermissive]

[cclauss]

Unfortunately the continuous integration tests on the node-ffi-napi repo have not been updated in three years and they run on a long expired version of Node.js. Those tests need to be brought up to date and the relevant bugs fixed.

• https://github.com/node-ffi-napi/node-ffi-napi/blob/master/.github/workflows/configure.yml
• AppVeyor nodejs_version: 16, 18, 20 node-ffi-napi/node-ffi-napi#255

Closing in favor of

• PLEASE ARCHIVE THIS REPO -- The code fails on modern Node.js node-ffi-napi/node-ffi-napi#269 and
• Upgrade GitHub Actions node-ffi-napi/node-ffi-napi#268
  @TooTallNate

[genaris]

So basically the only explanation is that node-ffi-napi is too old and is not going to be supported anymore? Isn't there any workaround that does not involve using other FFI libraries?

[cclauss]

There is a fork that some people have said works but your mileage may vary...

• https://github.com/lwahonen/node-ffi-napi

[genaris]

Well, it seems that the issue started after 7a216d5, since it introduces a breaking change in napi_finalize experimental feature (it now defines node_api_nogc_finalizeand node_api_nogc_env). This breaks node-ffi-napi because it is unfortunately being built with NAPI_EXPERIMENTAL flag set (it seems it was enabled temporarily, waiting for the release of node 12.17, but probably was left by mistake or the fact that the repo is unmaintained).

I ended up updating the fork at https://github.com/2060-io/node-ffi-napi, which was created to fix other issues (with its sibling ref-napi). I'm currently testing with the npm release 4.0.8, so far so good!

[Galkon]

Well, it seems that the issue started after 7a216d5, since it introduces a breaking change in napi_finalize experimental feature (it now defines node_api_nogc_finalizeand node_api_nogc_env). This breaks node-ffi-napi because it is unfortunately being built with NAPI_EXPERIMENTAL flag set (it seems it was enabled temporarily, waiting for the release of node 12.17, but probably was left by mistake or the fact that the repo is unmaintained).

I ended up updating the fork at https://github.com/2060-io/node-ffi-napi, which was created to fix other issues (with its sibling ref-napi). I'm currently testing with the npm release 4.0.8, so far so good!

If only your fork worked in electron too :(

[btsimonh]

@genaris - you may wish to enable issues on your repo ( https://github.com/2060-io/node-ffi-napi), so I could add this comment:
pls update to "node-gyp-build": "^4.8.2",
This avoids using old node-gyp-build without shell:true for windows, which has taken me all day to find :(.

[genaris]

Thanks @btsimonh! I've enabled issues in my repo.