Added memory option for --key-value-storage #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madeline Murray <madeline.taylor@gmail.com>
docs/Reference/CLI/CLI-Syntax.md
Outdated
| @@ -511,6 +511,8 @@ If a name is not specified, the name section is not included in the client ID. F | |||
| The key-value storage to use. Use this option only if using a storage system provided with a | |||
| plugin. The default is `rocksdb`. | |||
|
|
|||
| For ease of use when using a debugger, use the `memory` option. | |||
There was a problem hiding this comment.
Add a link to the option?
EDIT: link to the option title in this doc
There was a problem hiding this comment.
I think this needs more caveats that tell the casual reader "You probably don't want this option". The release notes say "Added memory as an option to --key-value-storage. This ephemeral storage is intended for sync testing and debugging. "
There was a problem hiding this comment.
Updated to make this clearer
There was a problem hiding this comment.
@NicolasMassart - I don't understand your comment?
|
@shemnon - is the updated version better? |
NicolasMassart
approved these changes
Jan 11, 2021
shemnon
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added memory option for --key-value-storage