Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added memory option for --key-value-storage #592

Merged
merged 4 commits into from
Jan 29, 2021
Merged

Added memory option for --key-value-storage #592

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b299a4
memoryStorage
MadelineAu Dec 30, 2020
b9d797d
rework
MadelineAu Jan 11, 2021
deaeff3
Merge branch 'master' into memoryStorage
MadelineMurray Jan 11, 2021
af3db90
Merge branch 'master' into memoryStorage
MadelineMurray Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/Reference/CLI/CLI-Syntax.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,8 @@ If a name is not specified, the name section is not included in the client ID. F
The key-value storage to use. Use this option only if using a storage system provided with a
plugin. The default is `rocksdb`.

For ease of use when using a debugger, use the `memory` option.
Copy link
Contributor

@NicolasMassart NicolasMassart Jan 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to the option?
EDIT: link to the option title in this doc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hyperledger/besu#1617 ?

I think this needs more caveats that tell the casual reader "You probably don't want this option". The release notes say "Added memory as an option to --key-value-storage. This ephemeral storage is intended for sync testing and debugging. "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to make this clearer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicolasMassart - I don't understand your comment?


### `logging`

=== "Syntax"
Expand Down