Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for RPC performance regression #4099

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Conversation

diega
Copy link
Contributor

@diega diega commented Jul 13, 2022

Signed-off-by: Diego López León dieguitoll@gmail.com

PR description

PR #3695 uses i.o.v.e.web.Route#blockingHandler to attend JSON-RPC HTTP requests, but according documentation it does it linearly. This PR adds ordered=false to let vert.x parallelize the processing.

Fixed Issue(s)

fixes: #3959

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Signed-off-by: Diego López León <dieguitoll@gmail.com>
@non-fungible-nelson
Copy link
Contributor

Hey @diega - can you move this from draft? We have observed the fix working in some user testing, waiting for confirmation from @ahamlat but I think its safe to open a PR

@diega diega marked this pull request as ready for review July 18, 2022 17:08
Copy link
Contributor

@mbaxter mbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garyschulte
Copy link
Contributor

🚢

@garyschulte garyschulte enabled auto-merge (squash) July 18, 2022 19:27
@garyschulte garyschulte merged commit a08ee36 into hyperledger:main Jul 18, 2022
@diega diega deleted the 3959_fix branch July 19, 2022 00:11
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…4099)

Signed-off-by: Diego López León <dieguitoll@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC performance regression since 22.4.0-RC2
5 participants