Remove getbyblocknumber from flexibleprivacyprecompiledcontract #5221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…PrecompiledContract
…PrecompiledContract
gfukushima
force-pushed
the
remove-getbyblocknumber-from-FlexiblePrivacyPrecompiledContract
branch
from
5b4bc58
to
c9719d1
Compare
siladu
approved these changes
Mar 16, 2023
macfarla
approved these changes
Mar 16, 2023
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…PrecompiledContract
jframe
reviewed
Mar 16, 2023
| @@ -1344,17 +1347,19 @@ private void createLogsSubscriptionService( | |||
|
|
|||
| private void createPrivateTransactionObserver( | |||
There was a problem hiding this comment.
Don't know how feasible this is, but adding a test for this would be good. But it might already be covered by a test at another level.
gfukushima
deleted the
remove-getbyblocknumber-from-FlexiblePrivacyPrecompiledContract
branch
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
…rledger#5221) <!-- Thanks for sending a pull request! Please check out our contribution guidelines: --> <!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md --> ## PR description This PR aims to remove the usage of getByBlockNumber from the FlexiblePrivacyPrecompiledContract. As far as analysis shows the only requirement is to get a protocolSpec (it doesn't matter which one) currently it always fetches the protocolSpec for block number 1 which can vary according to the network config. We're changing that get the protocolSpec for block 0 which is the only block we always have the header. AT nonmainnet on circle CI Pipeline - 21048 ## Fixed Issue(s) <!-- Please link to fixed issue(s) here using format: fixes #<issue number> --> <!-- Example: "fixes #2" --> Fixes hyperledger#5160 ## Documentation - [x] I thought about documentation and added the `doc-change-required` label to this PR if [updates are required](https://wiki.hyperledger.org/display/BESU/Documentation). ## Acceptance Tests (Non Mainnet) - [x] I have considered running `./gradlew acceptanceTestNonMainnet` locally if my PR affects non-mainnet modules. ## Changelog - [x] I thought about the changelog and included a [changelog update if required](https://wiki.hyperledger.org/display/BESU/Changelog). --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…rledger#5221) <!-- Thanks for sending a pull request! Please check out our contribution guidelines: --> <!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md --> ## PR description This PR aims to remove the usage of getByBlockNumber from the FlexiblePrivacyPrecompiledContract. As far as analysis shows the only requirement is to get a protocolSpec (it doesn't matter which one) currently it always fetches the protocolSpec for block number 1 which can vary according to the network config. We're changing that get the protocolSpec for block 0 which is the only block we always have the header. AT nonmainnet on circle CI Pipeline - 21048 ## Fixed Issue(s) <!-- Please link to fixed issue(s) here using format: fixes #<issue number> --> <!-- Example: "fixes #2" --> Fixes hyperledger#5160 ## Documentation - [x] I thought about documentation and added the `doc-change-required` label to this PR if [updates are required](https://wiki.hyperledger.org/display/BESU/Documentation). ## Acceptance Tests (Non Mainnet) - [x] I have considered running `./gradlew acceptanceTestNonMainnet` locally if my PR affects non-mainnet modules. ## Changelog - [x] I thought about the changelog and included a [changelog update if required](https://wiki.hyperledger.org/display/BESU/Changelog). --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR aims to remove the usage of getByBlockNumber from the FlexiblePrivacyPrecompiledContract. As far as analysis shows the only requirement is to get a protocolSpec (it doesn't matter which one) currently it always fetches the protocolSpec for block number 1 which can vary according to the network config. We're changing that get the protocolSpec for block 0 which is the only block we always have the header.
AT nonmainnet on circle CI
Pipeline - 21048
Fixed Issue(s)
Fixes #5160
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Acceptance Tests (Non Mainnet)
./gradlew acceptanceTestNonMainnetlocally if my PR affects non-mainnet modules.Changelog