Main project merge Aug 27th #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
… than its parent (#4066) * After merge add a rule to check that the current block is more recent than its parent Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Update CHANGELOG Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Unit test Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Fix to return pre-merge protocol schedule when block difficulty is less that TTD Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
* adds interfaces for tracking merge state and forchoices * after 2 finalizations from fcu, disconnect any peers sending new blocks, or connecting with td > ttd * tests for preventing pow peers from joining * refactored to separate out merge logic Signed-off-by: Justin Florentine <justin+github@florentine.us>
* if block did not descend from the terminal block add it to the bad blocks Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* adds test coverage for bug * corrects root issue and covers the bug Signed-off-by: Justin Florentine <justin+github@florentine.us>
* Remove backward sync exception recursive nesting Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
#4098) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
…at should not be the case (#4102) * ignore 2 tests that assume that the system language is English, if that should not be the case Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
…tion post-merge sync. (#4104) Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: garyschulte <garyschulte@gmail.com>
* Add experimental config option to enable v5 discovery Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Move Taccat Isid from Active to Emeritus Maintainer. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
* Remove hash to append from the queue only if the step succeeds Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Create backward sync retries on demand Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
* add a merge-specific definiton of bestPeer and the supporting plumbing Signed-off-by: garyschulte <garyschulte@gmail.com> * set reached TTD when finishing a fast sync if appropriate Signed-off-by: garyschulte <garyschulte@gmail.com> * spdx header Signed-off-by: garyschulte <garyschulte@gmail.com> * fix BetterSyncTargetEvaluatorTest tests Signed-off-by: garyschulte <garyschulte@gmail.com>
…#4122) * check status of block propagation manager before starting or stopping Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* candidate fix for missing parent worldstate * add rollback if failure * fix persist trie log issue * add trielog manager * fix inmemory issue for bonsai Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Diego López León <dieguitoll@gmail.com>
* Update RocksDB default block cache size. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
* add malloc arena params to besu startup * add jemalloc preload to besu startup * add jemalloc lib download to docker jvm images * use 5.* for jemalloc-dev version * add jemalloc to circleci containers for acceptance tests Signed-off-by: garyschulte <garyschulte@gmail.com>
* useful response improves reputation Signed-off-by: Stefan <stefan.pingel@consensys.net>
* remove the limit for the incoming message size. The size is limited on the RLPx layer (16.7MB) Signed-off-by: Stefan <stefan.pingel@consensys.net>
Signed-off-by: garyschulte <garyschulte@gmail.com>
update changelog for release Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Release 22.7.0-RC2 of Hyperledger Besu Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Cleanup repository references and limit scope of non-mavenCentral repositories. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
* if merge enabled, wrap two clique rules in composed Attached rule to enable fast-sync to proceed normally for post-merge networks * move BlockPropagationManager warning to debug until #4274 Signed-off-by: garyschulte <garyschulte@gmail.com>
* breaks pandas up, test coverage Signed-off-by: Justin Florentine <justin+github@florentine.us>
* implement tentative mainnet TTD * fix unit test breakage * add to change log Signed-off-by: garyschulte <garyschulte@gmail.com>
* Refactor retrying peer task switching peers at every try RetryingGetBlockFromPeersTask had a problem that prevented to complete when all the peers were tried without success, and that also had the consequence to not removing the failed requested block for the internal caches in BlockPropagationManager, that could cause a stall since that block will to be tried to be retrieved again. Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Paris block definition was set up prior to gray glacier. Update the base to be gray glacier. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
The four instances of gas in the CALL operations are all implemented identically. Refactor the method into the abstract parent. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
* upreved to new snapshot * download links / shas in changelog Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Adrian Sutton <adrian@symphonious.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
* Filter out disconnected peers when fetching available peers Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Revert "ignore the tests that use tessera enclave via docker (#4297)" This reverts commit 98e214c. Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * lock version of tessera and make public Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
* interprete an empty string (0x80) as an unsigned byte of 0 Signed-off-by: Stefan <stefan.pingel@consensys.net> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
…ts (#4286) * create AbstractJsonRpcTest to enable future code reuse in similar tests Signed-off-by: Pedro Novais <jpvnovais@gmail.com> Co-authored-by: Antony Denyer <git@antonydenyer.co.uk>
* latest ubuntu for xl-machine-ex * tessera docker image version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Pedro Novais <jpvnovais@gmail.com> Signed-off-by: Pedro Novais <jpvnovais@gmail.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
* docker version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Stacktrace can be retrieved by increasing the log level Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Pedro Novais <jpvnovais@gmail.com> Co-authored-by: Antony Denyer <git@antonydenyer.co.uk> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Removed ommers and added base fee. Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
…4271) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
elenduuche
pushed a commit
that referenced
this pull request
Aug 16, 2023
…perledger#5182) <!-- Thanks for sending a pull request! Please check out our contribution guidelines: --> <!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md --> ## PR description There is an issue when restarting Besu when a backward sync session is running, since after the restart it is possible that the Consensus client sends a FcU or a NewPayload for a block that is present in the backward sync storage, but not yet imported, so not on the main chain, but still the backward sync thinks it should not do anything with that block, so it returns like it has completed the sync, but since the sync is not done actually then the internal error that the finalize block is not present. The solution is to persist the backward sync status, so in case of a restart, it can resume from where it was interrupted. ## Fixed Issue(s) <!-- Please link to fixed issue(s) here using format: fixes #<issue number> --> <!-- Example: "fixes #2" --> fixes hyperledger#5053 ## Documentation - [x] I thought about documentation and added the `doc-change-required` label to this PR if [updates are required](https://wiki.hyperledger.org/display/BESU/Documentation). ## Acceptance Tests (Non Mainnet) - [x] I have considered running `./gradlew acceptanceTestNonMainnet` locally if my PR affects non-mainnet modules. ## Changelog - [x] I thought about the changelog and included a [changelog update if required](https://wiki.hyperledger.org/display/BESU/Changelog). --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
elenduuche
pushed a commit
that referenced
this pull request
Aug 16, 2023
…rledger#5221) <!-- Thanks for sending a pull request! Please check out our contribution guidelines: --> <!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md --> ## PR description This PR aims to remove the usage of getByBlockNumber from the FlexiblePrivacyPrecompiledContract. As far as analysis shows the only requirement is to get a protocolSpec (it doesn't matter which one) currently it always fetches the protocolSpec for block number 1 which can vary according to the network config. We're changing that get the protocolSpec for block 0 which is the only block we always have the header. AT nonmainnet on circle CI Pipeline - 21048 ## Fixed Issue(s) <!-- Please link to fixed issue(s) here using format: fixes #<issue number> --> <!-- Example: "fixes #2" --> Fixes hyperledger#5160 ## Documentation - [x] I thought about documentation and added the `doc-change-required` label to this PR if [updates are required](https://wiki.hyperledger.org/display/BESU/Documentation). ## Acceptance Tests (Non Mainnet) - [x] I have considered running `./gradlew acceptanceTestNonMainnet` locally if my PR affects non-mainnet modules. ## Changelog - [x] I thought about the changelog and included a [changelog update if required](https://wiki.hyperledger.org/display/BESU/Changelog). --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
elenduuche
pushed a commit
that referenced
this pull request
Oct 11, 2023
…perledger#5182) <!-- Thanks for sending a pull request! Please check out our contribution guidelines: --> <!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md --> ## PR description There is an issue when restarting Besu when a backward sync session is running, since after the restart it is possible that the Consensus client sends a FcU or a NewPayload for a block that is present in the backward sync storage, but not yet imported, so not on the main chain, but still the backward sync thinks it should not do anything with that block, so it returns like it has completed the sync, but since the sync is not done actually then the internal error that the finalize block is not present. The solution is to persist the backward sync status, so in case of a restart, it can resume from where it was interrupted. ## Fixed Issue(s) <!-- Please link to fixed issue(s) here using format: fixes #<issue number> --> <!-- Example: "fixes #2" --> fixes hyperledger#5053 ## Documentation - [x] I thought about documentation and added the `doc-change-required` label to this PR if [updates are required](https://wiki.hyperledger.org/display/BESU/Documentation). ## Acceptance Tests (Non Mainnet) - [x] I have considered running `./gradlew acceptanceTestNonMainnet` locally if my PR affects non-mainnet modules. ## Changelog - [x] I thought about the changelog and included a [changelog update if required](https://wiki.hyperledger.org/display/BESU/Changelog). --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
elenduuche
pushed a commit
that referenced
this pull request
Oct 11, 2023
…rledger#5221) <!-- Thanks for sending a pull request! Please check out our contribution guidelines: --> <!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md --> ## PR description This PR aims to remove the usage of getByBlockNumber from the FlexiblePrivacyPrecompiledContract. As far as analysis shows the only requirement is to get a protocolSpec (it doesn't matter which one) currently it always fetches the protocolSpec for block number 1 which can vary according to the network config. We're changing that get the protocolSpec for block 0 which is the only block we always have the header. AT nonmainnet on circle CI Pipeline - 21048 ## Fixed Issue(s) <!-- Please link to fixed issue(s) here using format: fixes #<issue number> --> <!-- Example: "fixes #2" --> Fixes hyperledger#5160 ## Documentation - [x] I thought about documentation and added the `doc-change-required` label to this PR if [updates are required](https://wiki.hyperledger.org/display/BESU/Documentation). ## Acceptance Tests (Non Mainnet) - [x] I have considered running `./gradlew acceptanceTestNonMainnet` locally if my PR affects non-mainnet modules. ## Changelog - [x] I thought about the changelog and included a [changelog update if required](https://wiki.hyperledger.org/display/BESU/Changelog). --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog