Invalid params data #5241
Closed
Invalid params data #5241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
|
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
siladu
reviewed
Mar 20, 2023
| @@ -41,8 +41,10 @@ public JsonRpcResponse process( | |||
| try { | |||
| return method.response(request); | |||
| } catch (final InvalidJsonRpcParameters e) { | |||
| JsonRpcError invalidParamsError = JsonRpcError.INVALID_PARAMS; | |||
| invalidParamsError.setData(e.getMessage()); | |||
There was a problem hiding this comment.
This doesn't touch the Engine API does it?
I think error messages are part of the spec in some cases for that: https://github.com/ethereum/execution-apis/blob/main/src/engine/common.md#errors
|
On further inspection, calling setData() on an enum value seems like a dodgy hack so I think we need to refactor JsonRpcError to separate these two concepts. Closing this PR, needs further thought. Created an issue #5437 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
datato error in case of INVALID_PARAMS to give users more info as to what's gone wrongSee #4212 - possible solution to #5098
Not sure if this will break some hive tests?