-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23.4] Remove GoQuorum privacy #5303
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
|
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
with this change - if you send a GoQuorum private transaction via EthSigner, it is rejected with "method not enabled" because it sends a |
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a "find all" within Besu for goquorum and I found a few error codes in JsonRpcError.java that are related to goquorum privacy:
GOQUORUM_NO_PRIVATE_FOR
GOQUORUM_ONLY_STANDARD_MODE_SUPPORTED
GOQUORUM_LOOKUP_ID_NOT_AVAILABLE
GOQUORUM_V_VALUE
In RpcMethod.java I found
GOQUORUM_ETH_GET_QUORUM_PAYLOAD
GOQUORUM_STORE_RAW
In BlockHeader.java there is a method that returns the private logs bloom:
getPrivateLogsBloom()
We might be able to get rid of the v parameter for Transaction (org/hyperledger/besu/ethereum/core/Transaction.java)
There is a method on BlockProcessor line 149 that we should be able to get rid of
KeyValueSegmentIdentifier.java contains
GOQUORUM_PRIVATE_WORLD_STATE
GOQUORUM_PRIVATE_STORAGE
TransactionDecoderTest.java lines 41 and 88
That's all I can find right now :-)
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Thanks @pinges removed all those things! |
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Leaving EthSigner as is. User will get "method not enabled" if they try to send a GoQuorum private tx via EthSigner to Besu. |
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how this removes GoQuorumOptions
End of an era! |
Reminder to merge for tomorrow @macfarla |
* removed separate decoding logic * run non-mainnet ATs to make sure * remove goQuorum flag from everywhere * remove GOQUORUM api group * remove GoQuorum enclave, privacy params, RPCs and other related config * removed Goquorum related error codes, rpcMethod codes, privateBloom * removed v from transaction * removed private GoQuorum storage provider --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* removed separate decoding logic * run non-mainnet ATs to make sure * remove goQuorum flag from everywhere * remove GOQUORUM api group * remove GoQuorum enclave, privacy params, RPCs and other related config * removed Goquorum related error codes, rpcMethod codes, privateBloom * removed v from transaction * removed private GoQuorum storage provider --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Remove GoQuorum compatible privacy
Fixes #4886