Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncomment columns related to GoQuorum privacy #5350

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Apr 16, 2023

Addresses database backwards compatibility broken by 067a263

Fixes org.rocksdb.RocksDBException: Column families not opened: error

See #5303

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions
Copy link

github-actions bot commented Apr 16, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
  • I thought about the changelog and included a changelog update if required.

@macfarla
Copy link
Contributor Author

Testing

  • create main/data by starting besu built with main 080fe87
  • create 42f52e7/data by starting besu built with last good commit 42f52e7
  • start besu-main with --data-path="42f52e72be25e75704d5116646369ae09860bb4a/data" - get column families not opened error (reproducing reported issue)
  • create bring-back-column-fam/data by starting besu built with 402a004
  • start besu-42f52e72be25e75704d5116646369ae09860bb4a with --data-path="bring-back-column-fam/data" - successful startup (new code works with new db)
  • start besu-bring-back-column-fam with --data-path="42f52e72be25e75704d5116646369ae09860bb4a/data" - successful startup
  • start besu-bring-back-column-fam with --data-path="080fe87c816ca3b4e1ba55eb7306d3ef323b75af/data" - successful startup

Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally as well and the old database is working again now.

@macfarla macfarla merged commit 67dba23 into hyperledger:main Apr 16, 2023
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth trying in a later PR something to drop/destroy these column families? Instead of just keep them for backwards compatibility?

@macfarla
Copy link
Contributor Author

Is it worth trying in a later PR something to drop/destroy these column families? Instead of just keep them for backwards compatibility?

Maybe! I am not a database expert (clearly) so not sure of the pros and cons of this

parithosh pushed a commit to parithosh/besu that referenced this pull request Apr 17, 2023
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: parithosh <parithosh.jayanthi@ethereum.org>
@macfarla macfarla deleted the bring-back-column-families branch April 18, 2023 22:37
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants