fix account copy issue #6845
Merged
fix account copy issue #6845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
garyschulte
approved these changes
Mar 29, 2024
| @@ -60,6 +60,25 @@ public DiffBasedAccount( | |||
| this.immutable = !mutable; | |||
| } | |||
|
|
|||
| public DiffBasedAccount( | |||
There was a problem hiding this comment.
according to intellij, the 3rd and 4th constructors for DiffBasedAccount are unused. Can we drop those and add javadoc to the remaining constructors that indicate in what cases we want to use one over the other
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This pull request addresses a bug that was inadvertently introduced during a recent refactoring effort. The refactor, which was part of our ongoing improvements to our codebase, unfortunately led to an issue in the account copying functionality. Specifically, the process failed to include the account's code in the copy, which could potentially lead to errors during block imports.
f2c2512#diff-0d81f3f69e4b129c05c8c2b7b0bb3cd87abbc39555596df77b25c81dd7f612b1L106
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests