Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix account copy issue #6845

Merged
merged 4 commits into from
Mar 29, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ public BonsaiAccount(
toCopy.nonce,
toCopy.balance,
toCopy.codeHash,
toCopy.code,
mutable);
this.storageRoot = toCopy.storageRoot;
updatedStorage.putAll(toCopy.updatedStorage);
Expand All @@ -96,6 +97,7 @@ public BonsaiAccount(
tracked.getNonce(),
tracked.getBalance(),
tracked.getCodeHash(),
tracked.getCode(),
true);
this.storageRoot = Hash.EMPTY_TRIE_HASH;
updatedStorage.putAll(tracked.getUpdatedStorage());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,25 @@ public DiffBasedAccount(
this.immutable = !mutable;
}

public DiffBasedAccount(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to intellij, the 3rd and 4th constructors for DiffBasedAccount are unused. Can we drop those and add javadoc to the remaining constructors that indicate in what cases we want to use one over the other

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

final DiffBasedWorldView context,
final Address address,
final Hash addressHash,
final long nonce,
final Wei balance,
final Hash codeHash,
final Bytes code,
final boolean mutable) {
this.context = context;
this.address = address;
this.addressHash = addressHash;
this.nonce = nonce;
this.balance = balance;
this.codeHash = codeHash;
this.code = code;
this.immutable = !mutable;
}

public DiffBasedAccount(
final DiffBasedWorldView context,
final Address address,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/*
* Copyright Hyperledger Besu Contributors.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
* specific language governing permissions and limitations under the License.
*
* SPDX-License-Identifier: Apache-2.0
*/
package org.hyperledger.besu.ethereum.trie.diffbased.bonsai;

import static org.assertj.core.api.Assertions.assertThat;

import org.hyperledger.besu.datatypes.Address;
import org.hyperledger.besu.datatypes.Hash;
import org.hyperledger.besu.datatypes.Wei;
import org.hyperledger.besu.ethereum.trie.diffbased.bonsai.worldview.BonsaiWorldState;
import org.hyperledger.besu.evm.worldstate.UpdateTrackingAccount;

import org.apache.tuweni.bytes.Bytes;
import org.apache.tuweni.units.bigints.UInt256;
import org.junit.jupiter.api.Test;
import org.mockito.Mock;

public class BonsaiAccountTest {

@Mock BonsaiWorldState bonsaiWorldState;

@Test
void shouldCopyTrackedBonsaiAccountCorrectly() {
final BonsaiAccount trackedAccount =
new BonsaiAccount(
bonsaiWorldState,
Address.ZERO,
Hash.hash(Address.ZERO),
0,
Wei.ONE,
Hash.EMPTY_TRIE_HASH,
Hash.EMPTY,
true);
trackedAccount.setCode(Bytes.of(1));
final UpdateTrackingAccount<BonsaiAccount> bonsaiAccountUpdateTrackingAccount =
new UpdateTrackingAccount<>(trackedAccount);
bonsaiAccountUpdateTrackingAccount.setStorageValue(UInt256.ONE, UInt256.ONE);

final BonsaiAccount expectedAccount = new BonsaiAccount(trackedAccount, bonsaiWorldState, true);
expectedAccount.setStorageValue(UInt256.ONE, UInt256.ONE);
assertThat(new BonsaiAccount(bonsaiWorldState, bonsaiAccountUpdateTrackingAccount))
.isEqualToComparingFieldByField(expectedAccount);
}

@Test
void shouldCopyBonsaiAccountCorrectly() {
final BonsaiAccount account =
new BonsaiAccount(
bonsaiWorldState,
Address.ZERO,
Hash.hash(Address.ZERO),
0,
Wei.ONE,
Hash.EMPTY_TRIE_HASH,
Hash.EMPTY,
true);
account.setCode(Bytes.of(1));
account.setStorageValue(UInt256.ONE, UInt256.ONE);
assertThat(new BonsaiAccount(account, bonsaiWorldState, true))
.isEqualToComparingFieldByField(account);
}
}
Loading