5098 branch 7 update invalid blob gas used params #7408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…ion, apply spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…ion, apply spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…-branch-2-update-invalid-accounts-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…' into 5098-branch-3-update-invalid-address-hash-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…-branch-2-update-invalid-accounts-params
…' into 5098-branch-3-update-invalid-address-hash-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…-branch-2-update-invalid-accounts-params
…' into 5098-branch-3-update-invalid-address-hash-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…ounts-params' into 5098-branch-2-update-invalid-accounts-params
…' into 5098-branch-3-update-invalid-address-hash-params
…rams' into 5098-branch-4-update-invalid-address-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…' into 5098-branch-3-update-invalid-address-hash-params
…rams' into 5098-branch-4-update-invalid-address-params
… into 5098-branch-5-update-invalid-auth-params
…to 5098-branch-6-update-invalid-blob-count
…o 5098-branch-7-update-invalid-blob-gas-used-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…dJsonRpcParameters Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
… into 5098-branch-5-update-invalid-auth-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…to 5098-branch-6-update-invalid-blob-count
…o 5098-branch-7-update-invalid-blob-gas-used-params
… into 5098-branch-5-update-invalid-auth-params
…to 5098-branch-6-update-invalid-blob-count
…o 5098-branch-7-update-invalid-blob-gas-used-params
Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>
…to 5098-branch-6-update-invalid-blob-count
…o 5098-branch-7-update-invalid-blob-gas-used-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…to 5098-branch-6-update-invalid-blob-count
…o 5098-branch-7-update-invalid-blob-gas-used-params
macfarla
reviewed
Aug 11, 2024
| RpcErrorType.INVALID_BLOB_GAS_USED_PARAMS, "Missing blob gas used field"); | ||
| } else if (payloadParameter.getExcessBlobGas() == null) { | ||
| return ValidationResult.invalid( | ||
| RpcErrorType.INVALID_PARAMS, "non-null ExcessBlobGas pre-cancun"); |
There was a problem hiding this comment.
is there not a specific error code for this one?
There was a problem hiding this comment.
There is, but it will be coming in a later PR as I'm updating them in alphabetical order to ensure I don't miss any. This is the 7th PR in the series, breaking apart #7389 which is too gigantic to review.
macfarla
approved these changes
Aug 12, 2024
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
* 5098: Add RpcErrorTypes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> --------- Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Update code to use RpcErrorType.INVALID_BLOB_GAS_USED_PARAMS
Fixed Issue(s)
#5098