Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate DIDCommAgent and adding Tasks #277

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Aug 29, 2024

Description:

Precursor to OIDC, splitting Agent into separate DIDComm Agent.

Avoiding breaking changes by exporting the DIDComm Agent aliased under the previous Agents name, interface should be identical.

Started implementing a command pattern, with Tasks and Contexts, to enable easy resharing of code between Agents as well as addressing the growing coupling and dependency hell, plus desired logging functionality.

Replaced AgentCredentials, DIDHigherFunctions, and Invitations with tasks.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@curtis-h curtis-h self-assigned this Aug 29, 2024
Copy link

github-actions bot commented Aug 29, 2024

Lines Statements Branches Functions
Coverage: 76%
76.21% (2900/3805) 65.54% (1404/2142) 81.43% (750/921)

JUnit

Tests Skipped Failures Errors Time
527 6 💤 0 ❌ 0 🔥 56.054s ⏱️

@coveralls
Copy link

coveralls commented Aug 29, 2024

Pull Request Test Coverage Report for Build 10846400835

Details

  • 238 of 398 (59.8%) changed or added relevant lines in 19 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 72.279%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/edge-agent/didcomm/CreatePeerDID.ts 15 16 93.75%
src/apollo/Apollo.ts 2 4 50.0%
src/edge-agent/didcomm/HandleIssueCredential.ts 19 21 90.48%
src/edge-agent/didFunctions/Sign.ts 0 5 0.0%
src/edge-agent/didcomm/HandleOfferCredential.ts 44 49 89.8%
src/utils/guards.ts 5 10 50.0%
src/edge-agent/Agent.ts 5 12 41.67%
src/utils/tasks.ts 25 36 69.44%
src/edge-agent/didcomm/CreatePresentationRequest.ts 0 17 0.0%
src/edge-agent/didcomm/HandlePresentation.ts 0 20 0.0%
Files with Coverage Reduction New Missed Lines %
src/edge-agent/Agent.ts 5 54.76%
Totals Coverage Status
Change from base Build 10828967067: 0.1%
Covered Lines: 2833
Relevant Lines: 3720

💛 - Coveralls

@curtis-h curtis-h changed the title feat: seaprate DIDCommAgent and adding Tasks feat: separate DIDCommAgent and adding Tasks Aug 29, 2024
@curtis-h curtis-h mentioned this pull request Aug 29, 2024
6 tasks
Signed-off-by: Curtish <ch@curtish.me>
@curtis-h curtis-h force-pushed the feature/ATL-5751-agent-split branch from f1d44ff to 099de34 Compare September 13, 2024 09:12
@curtis-h curtis-h merged commit 3a8fd66 into main Sep 13, 2024
6 checks passed
@curtis-h curtis-h deleted the feature/ATL-5751-agent-split branch September 13, 2024 09:24
hyperledger-bot added a commit that referenced this pull request Oct 4, 2024
# [6.1.0](v6.0.1...v6.1.0) (2024-10-04)

### Bug Fixes

* bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5))
* e2e cucumber import ([#291](#291)) ([e569d79](e569d79))
* external build update for new generated code ([#264](#264)) ([460102a](460102a))
* main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff))
* make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0))
* next generation building tools and testing framework ([#258](#258)) ([54ead35](54ead35))
* nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7))
* noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c))
* package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3))
* rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42))
* sdk module resolution issues ([#290](#290)) ([f53d728](f53d728))
* update code-owners ([#281](#281)) ([b8409af](b8409af))

### Features

* Connectionless Offer ([#293](#293)) ([97e05e7](97e05e7))
* Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60))
* decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f))
* errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565))
* integrating error reporting protocol  ([#289](#289)) ([02430db](02430db))
* OIDC Agent ([#278](#278)) ([295e14f](295e14f))
* separate DIDCommAgent and adding Tasks ([#277](#277)) ([3a8fd66](3a8fd66))
elribonazo pushed a commit that referenced this pull request Oct 4, 2024
Signed-off-by: Curtish <ch@curtish.me>
hyperledger-bot added a commit that referenced this pull request Oct 4, 2024
# [6.2.0](v6.1.1...v6.2.0) (2024-10-04)

### Bug Fixes

* e2e cucumber import ([#291](#291)) ([e569d79](e569d79))
* next generation building tools and testing framework ([#258](#258)) ([54ead35](54ead35))
* sdk module resolution issues ([#290](#290)) ([f53d728](f53d728))

### Features

* Connectionless Offer ([#293](#293)) ([97e05e7](97e05e7))
* integrating error reporting protocol  ([#289](#289)) ([02430db](02430db))
* OIDC Agent ([#278](#278)) ([295e14f](295e14f))
* separate DIDCommAgent and adding Tasks ([#277](#277)) ([3a8fd66](3a8fd66))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants