Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e cucumber import #291

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix: e2e cucumber import #291

merged 2 commits into from
Sep 17, 2024

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Sep 17, 2024

Description:

fix e2e tests not working due to some incompatibilities. We've proven the SDK works in the needed environments but for some reason we were unable to run e2e until this fixes have been implemented

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo elribonazo requested review from amagyar-iohk, curtis-h and milosh86 and removed request for amagyar-iohk September 17, 2024 11:41
@elribonazo elribonazo force-pushed the fix/e2e-cucumber-import branch from f11ea49 to 8357e88 Compare September 17, 2024 11:42
@elribonazo elribonazo changed the title Fix/e2e cucumber import fix:e2e cucumber import Sep 17, 2024
@elribonazo elribonazo changed the title fix:e2e cucumber import fix: e2e cucumber import Sep 17, 2024
Copy link

github-actions bot commented Sep 17, 2024

Lines Statements Branches Functions
Coverage: 77%
78.15% (3428/4386) 67.21% (1507/2242) 81.73% (828/1013)

@coveralls
Copy link

coveralls commented Sep 17, 2024

Pull Request Test Coverage Report for Build 10902597003

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 74.273%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/mercury/didcomm/Wrapper.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 10902579776: 0.03%
Covered Lines: 3323
Relevant Lines: 4261

💛 - Coveralls

Copy link
Contributor

@milosh86 milosh86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
@elribonazo elribonazo force-pushed the fix/e2e-cucumber-import branch from 8357e88 to 12fee72 Compare September 17, 2024 12:02
@elribonazo elribonazo merged commit e569d79 into main Sep 17, 2024
6 checks passed
@elribonazo elribonazo deleted the fix/e2e-cucumber-import branch September 17, 2024 12:12
hyperledger-bot added a commit that referenced this pull request Oct 4, 2024
# [6.1.0](v6.0.1...v6.1.0) (2024-10-04)

### Bug Fixes

* bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5))
* e2e cucumber import ([#291](#291)) ([e569d79](e569d79))
* external build update for new generated code ([#264](#264)) ([460102a](460102a))
* main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff))
* make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0))
* next generation building tools and testing framework ([#258](#258)) ([54ead35](54ead35))
* nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7))
* noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c))
* package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3))
* rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42))
* sdk module resolution issues ([#290](#290)) ([f53d728](f53d728))
* update code-owners ([#281](#281)) ([b8409af](b8409af))

### Features

* Connectionless Offer ([#293](#293)) ([97e05e7](97e05e7))
* Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60))
* decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f))
* errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565))
* integrating error reporting protocol  ([#289](#289)) ([02430db](02430db))
* OIDC Agent ([#278](#278)) ([295e14f](295e14f))
* separate DIDCommAgent and adding Tasks ([#277](#277)) ([3a8fd66](3a8fd66))
elribonazo added a commit that referenced this pull request Oct 4, 2024
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
hyperledger-bot added a commit that referenced this pull request Oct 4, 2024
# [6.2.0](v6.1.1...v6.2.0) (2024-10-04)

### Bug Fixes

* e2e cucumber import ([#291](#291)) ([e569d79](e569d79))
* next generation building tools and testing framework ([#258](#258)) ([54ead35](54ead35))
* sdk module resolution issues ([#290](#290)) ([f53d728](f53d728))

### Features

* Connectionless Offer ([#293](#293)) ([97e05e7](97e05e7))
* integrating error reporting protocol  ([#289](#289)) ([02430db](02430db))
* OIDC Agent ([#278](#278)) ([295e14f](295e14f))
* separate DIDCommAgent and adding Tasks ([#277](#277)) ([3a8fd66](3a8fd66))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants