Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scikit-learn segfaults on macOS (wheels issue) #2831

Merged

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Oct 4, 2021

The scikit-learn 1.0 wheels seem to cause segmentation faults of the test suite on macos on github CI. The azure pipelines builds work fine because they use conda-forge packages.
See scikit-learn/scikit-learn#21227.

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #2831 (2480360) into RELEASE_next_patch (2acd775) will decrease coverage by 1.75%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           RELEASE_next_patch    #2831      +/-   ##
======================================================
- Coverage               77.27%   75.51%   -1.76%     
======================================================
  Files                     202      202              
  Lines                   30111    30111              
  Branches                 6580     6580              
======================================================
- Hits                    23267    22738     -529     
- Misses                   5102     5638     +536     
+ Partials                 1742     1735       -7     
Impacted Files Coverage Δ
hyperspy/misc/machine_learning/import_sklearn.py 50.00% <0.00%> (-50.00%) ⬇️
hyperspy/learn/mva.py 45.00% <0.00%> (-37.93%) ⬇️
hyperspy/utils/peakfinders2D.py 55.86% <0.00%> (-35.20%) ⬇️
hyperspy/misc/axis_tools.py 55.55% <0.00%> (-22.23%) ⬇️
hyperspy/learn/svd_pca.py 92.10% <0.00%> (-3.95%) ⬇️
hyperspy/_signals/lazy.py 88.10% <0.00%> (-2.58%) ⬇️
hyperspy/signal.py 74.04% <0.00%> (-2.20%) ⬇️
hyperspy/misc/utils.py 86.14% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2acd775...2480360. Read the comment docs.

@jlaehne jlaehne merged commit 294abb7 into hyperspy:RELEASE_next_patch Oct 7, 2021
@ericpre ericpre deleted the test_segmentation_fault_macos branch October 7, 2021 13:26
@ericpre ericpre added this to the v1.6.5 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants