-
-
Notifications
You must be signed in to change notification settings - Fork 25.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD Fixes osx build by downgrading to 11.X [cd build] #21227
Conversation
Some experiments with different combinations:
In all cases the wheels built with this PR using libomp 11.0.1 works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the investigation. Looks good to me as a stopgap solution.
For the longer term we might have to standardize the wheel packages of the scipy stack to all use the same version of the OpenMP runtimes for each platform...
That might involve some coordination effort via a dedicated SPEC document. This could also help with OpenBLAS / OpenMP interactions that we struggle to understand (e.g. #20642).
But reading the discussion in #21182, maybe this is just a bug in the new 12 and 13 versions of libomp, see: https://bugs.llvm.org/show_bug.cgi?id=50579#c1 @thomasjpfan next time you conduct such investigations, it might be interesting to log the output of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do that until libomp 12 gets fixed
Reference Issues/PRs
Fixes #21182
What does this implement/fix? Explain your changes.
There are issues with libomp 12 on OSX. This PR downgrades the libomp version to 11.0.1.
I tested the wheel built by github actions on my osx python 3.9 and this fix works.
When testing this locally, the wheels work when
numpy
is installed throughpip
and fails whennumpy
is installed throughconda
. The biggest different I see is that withconda
,llvm-openmp==12.0.1
is installed.The CI does not catch this error because everything is installed through
pip
.XREF: microsoft/LightGBM#4229