-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support i18next v22 type augmentation #1997
Conversation
I'll debug tomorrow, but any help appreciated links to keep an eye on (by @adrai)
Ideally I'd like to provide a specific test for types |
@pedrodurek any chance to help @belgattitude with this? |
Sorry guys, It's been a tough week. I'll have some time tomorrow to look into it. |
Hey @belgattitude, that's happening because |
12.1 is the npm released version, but on master everything is up-to-date @pedrodurek |
Once we create a new version for "overrides": {
"next-i18next": {
"react-i18next": "12.0.0",
"i18next": "22.0.3"
}
} |
@belgattitude can you check that overrides? |
@belgattitude as soon as you think we're ready for releasing, let me know... probably still waiting for this #1998 ? |
Cool, gonna check tomorrow. Make sense |
Socket Security Pull Request ReportDependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again. 😵💫 Bin script confusionThis package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack Consider removing one of the conflicting packages. Packages should only export bin scripts with their name
Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Change example to support the new i18next v22 types augmentation.
To update look at https://github.com/i18next/next-i18next/pull/1997/files#diff-53f0261e2e3a0e94c11e361fb2729a6d2995921dca99da95aa77209f66226156