-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use EU URL for Site Verify #19
Comments
yes, but see also #11 We want to make the URLs fully configurable to also support other alternative servers, so we would need two string fields for widget and API URL. Or an additional option "custom URLs2. We can introduce this a a breaking change and / or migrate configuration. Are you interested to make a pull request? Otherwise we would probably tackle this, but it will take some time. |
Yeah, I saw that... For now, I would only make a PR for a simple "if EU endpoint is enabled, use EU URL for site verify" feature. This is already better than nothing IMHO. Right? If you want to extend this even further in the future, fine for me. However, I do not have a use case for this now. |
Ok fine with me, go ahead |
Currently, the
siteverify
call is done with a static URL:magento2-friendly-captcha/Model/Validate.php
Line 81 in 390adb5
According to https://docs.friendlycaptcha.com/#/eu_endpoint, it is also possible to use the EU URL for the
siteverify
call. Hence, I think we should use the EU URL ifimi_friendly_captcha/general/eu_endpoint
is enabled.The text was updated successfully, but these errors were encountered: