Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EU URL for Site Verify #19

Closed
sprankhub opened this issue Mar 23, 2023 · 3 comments
Closed

Use EU URL for Site Verify #19

sprankhub opened this issue Mar 23, 2023 · 3 comments

Comments

@sprankhub
Copy link
Contributor

Currently, the siteverify call is done with a static URL:

$curl->post('https://api.friendlycaptcha.com/api/v1/siteverify', $parameters);

According to https://docs.friendlycaptcha.com/#/eu_endpoint, it is also possible to use the EU URL for the siteverify call. Hence, I think we should use the EU URL if imi_friendly_captcha/general/eu_endpoint is enabled.

@amenk
Copy link
Member

amenk commented Mar 23, 2023

yes, but see also #11

We want to make the URLs fully configurable to also support other alternative servers, so we would need two string fields for widget and API URL. Or an additional option "custom URLs2.

We can introduce this a a breaking change and / or migrate configuration.

Are you interested to make a pull request? Otherwise we would probably tackle this, but it will take some time.

@sprankhub
Copy link
Contributor Author

Yeah, I saw that...

For now, I would only make a PR for a simple "if EU endpoint is enabled, use EU URL for site verify" feature. This is already better than nothing IMHO. Right?

If you want to extend this even further in the future, fine for me. However, I do not have a use case for this now.

@amenk
Copy link
Member

amenk commented Mar 23, 2023

Ok fine with me, go ahead

@amenk amenk closed this as completed in eca226b Mar 23, 2023
amenk added a commit that referenced this issue Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants