Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for HitachiAirToAirHeatPump #364

Merged
merged 28 commits into from
Jul 14, 2021

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Jan 27, 2021

Based on https://github.com/dotvav/aasivak/blob/master/Aasivak.py and https://pastebin.com/HZKsEPjU.

Great work by @aasivak, which I try to port bit by bit... Feel free to chime in.

@iMicknl iMicknl linked an issue Jan 27, 2021 that may be closed by this pull request
@iMicknl iMicknl changed the title Add Hitaching Airconditioning Add support for HitachiAirToAirHeatPump Jan 27, 2021
@xorassistant
Copy link

Hi @iMicknl

We also have an Hitachi Heating System(HitachiAirToWaterMainComponent), this is similair to the one you have put into the Tahoma integration.

Only the device is not supported the following DEBUG is coming forward:
DEBUG-HitachiAirToWaterMainComponent.txt

2021-02-11 12:45:45 DEBUG (MainThread) [custom_components.tahoma.coordinator] Initialized DataUpdateCoordinator with 0:00:30 interval. 2021-02-11 12:45:45 DEBUG (MainThread) [custom_components.tahoma.coordinator] EventName.DEVICE_STATE_CHANGED/None (device: modbus://1233-4770-7251/4002825/1#1, state: None -> None) 2021-02-11 12:45:45 DEBUG (MainThread) [custom_components.tahoma] Finished fetching TaHoma Event Fetcher data in 0.052 seconds 2021-02-11 12:45:45 INFO (MainThread) [custom_components.tahoma] HomeKit support detected with setup code 145-51-529. 2021-02-11 12:45:45 DEBUG (MainThread) [custom_components.tahoma] Added device (internal:TSKAlarmComponent - Alarm - TSKAlarmController - internal://1233-4770-7251/alarm/0) 2021-02-11 12:45:45 DEBUG (MainThread) [custom_components.tahoma] Unsupported device detected (modbus:YutakiMainComponent - HitachiHeatingSystem - HitachiAirToWaterMainComponent - modbus://1233-4770-7251/4002825/1#1) 2021-02-11 12:45:45 DEBUG (MainThread) [custom_components.tahoma] Unsupported device detected (modbus:YutakiV2Zone1Component - HitachiHeatingSystem - HitachiAirToWaterHeatingZone - modbus://1233-4770-7251/4002825/1#2) 2021-02-11 12:45:45 DEBUG (MainThread) [custom_components.tahoma] Unsupported device detected (modbus:YutakiRoomThermostatZone1Component - HeatingSystem - HitachiThermostat - modbus://1233-4770-7251/4002825/1#6) 2021-02-11 12:45:45 DEBUG (MainThread) [custom_components.tahoma] Unsupported device detected (modbus:YutakiRoomThermostatZone2Component - HeatingSystem - HitachiThermostat - modbus://1233-4770-7251/4002825/1#7) 2021-02-11 12:45:45 DEBUG (MainThread) [custom_components.tahoma] Added device (modbus:YutakiV2SpaceHeatingElectricalEnergyConsumptionComponent - ElectricitySensor - CumulativeElectricPowerConsumptionSensor - modbus://1233-4770-7251/4002825/1#9) 2021-02-11 12:45:45 DEBUG (MainThread) [custom_components.tahoma] Added device (ovp:ModbusMainController - Generic - unknown - ovp://1233-4770-7251/4002825) 2021-02-11 12:45:45 DEBUG (MainThread) [custom_components.tahoma] Added device (rts:VenetianBlindRTSComponent - VenetianBlind - UpDownVenetianBlind - rts://1233-4770-7251/16755180) 2021-02-11 12:45:45 DEBUG (MainThread) [custom_components.tahoma] Added gateway (1233-4770-7251 - GatewayType.TAHOMA_V2 - GatewaySubType.TAHOMA_PRO) 2021-02-11 12:46:18 DEBUG (MainThread) [custom_components.tahoma.coordinator] EventName.DEVICE_STATE_CHANGED/None (device: modbus://1233-4770-7251/4002825/1#1, state: None -> None) 2021-02-11 12:46:18 DEBUG (MainThread) [custom_components.tahoma.coordinator] EventName.DEVICE_STATE_CHANGED/None (device: modbus://1233-4770-7251/4002825/1#1, state: None -> None) 2021-02-11 12:46:18 DEBUG (MainThread) [custom_components.tahoma] Finished fetching TaHoma Event Fetcher data in 0.121 seconds

Do you see a way to also put this Hitachi into the intergration?

@iMicknl
Copy link
Owner Author

iMicknl commented Feb 11, 2021

@xorassistant I am afraid that this device is slightly different. We are always willing to investigating the addition of new devices, however as you can see we are limited time-wise and looking for more contributors.

Could you create a new issue and share all information required by the template? This will help us track new requests.

@iMicknl iMicknl marked this pull request as ready for review May 27, 2021 16:27
@iMicknl iMicknl force-pushed the feature/support_HitachiAirToAirHeatPump branch from 2510d81 to e503973 Compare May 27, 2021 18:44
vlebourl
vlebourl previously approved these changes May 28, 2021
@iMicknl iMicknl changed the title Add support for HitachiAirToAirHeatPump Add basic support for HitachiAirToAirHeatPump Jul 14, 2021
iMicknl and others added 3 commits July 15, 2021 00:25
commit 1bbacf1
Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com>
Date:   Wed Jul 14 15:14:39 2021 -0700

    Add basic support for AtlanticPassAPCHeatingAndCoolingZone (#380)

commit 4a77161
Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com>
Date:   Wed Jul 14 14:52:07 2021 -0700

    Adds basic support for AtlanticElectricalHeaterWithAdjustableTemperatureSetpoint (#362)

commit 93a02ff
Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com>
Date:   Wed Jul 14 14:30:49 2021 -0700

    Add support for AtlanticElectricalTowelDryer (#423)

    * Add scaffold for feature/AtlanticElectricalTowelDryer

    * Update presets and other features

    * First clean up

    * remove comments

commit a4709cd
Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com>
Date:   Wed Jul 14 14:18:00 2021 -0700

    Adjust Atlantic Electrical Heater to new standards and fix issues (#454)

    * Adjust Atlantic Electrical Heater to new standards and fix issues

    * Add comfort mode

    * Add missing extra comfort presets

commit 65de131
Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com>
Date:   Wed Jul 14 13:41:35 2021 -0700

    Add more information regarding Model and Manufacturer (#474)

commit 76d566c
Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com>
Date:   Wed Jul 14 11:56:06 2021 -0700

    Improve reauth, Config Flow and error handling (#452)

commit 847ee29
Author: Thibaut <thibaut@etienne.pw>
Date:   Wed Jul 14 19:09:43 2021 +0200

    Fix is_opening/closing for RTS devices (#464)

    Co-authored-by: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com>

commit 560db42
Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com>
Date:   Wed Jul 14 10:01:12 2021 -0700

    Update pyhoma and require latest Home Assistant version (#473)

commit 242e21d
Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com>
Date:   Wed Jul 14 08:01:55 2021 -0700

    Currently stale issues are closed too soon (#470)

commit c467aa4
Author: Thibaut <thibaut@etienne.pw>
Date:   Tue Jun 29 17:13:52 2021 +0200

    Fix is_opening/is_closing for RTS covers (#463)

commit 60f0766
Author: Thibaut <thibaut@etienne.pw>
Date:   Mon Jun 21 09:17:18 2021 +0200

    Support is_opening/closing when moving position (#460)

commit 39f485e
Author: Thibaut <thibaut@etienne.pw>
Date:   Mon May 31 17:27:48 2021 +0200

    Remove setPosition (#455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants