3D tiles: fix a bug and improve perfs #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jailln
force-pushed
the
fix/2074-3dtiles
branch
from
279c57d to
6bbe7d1
Compare
Desplandis
requested changes
Feb 8, 2024
jailln
force-pushed
the
fix/2074-3dtiles
branch
3 times, most recently
from
c51b51c to
5c424d0
Compare
…re-filling BREAKING CHANGES: * C3DTFeature constructor parameters changed from (tileId, batchId, groups, info, userData, object3d) to (tileId, batchId, groups, userData, object3d) * C3DTilesLayer.findBatchTable() is not exposed in the API anymore
jailln
force-pushed
the
fix/2074-3dtiles
branch
from
5c424d0 to
3030326
Compare
Desplandis
approved these changes
Feb 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two changes:
Fixes BatchID in 3DTiles are float and negative #2074 (that also caused tiles to be removed and never loaded again when removed from the cache): the issue came from accessing threejs buffer attributes array directly instead of using the recommended
getX()method (which is not the same in the case of InterleavedBufferAttribute.Greatly improves 3D tiles perfs (see screenshots below) by reducing loading time overhead due to internal structures pre-filling (mainly for 3D tiles picking and style) -> part of these structures are now filled on first demand.
Screenshots
Performance profiling on
3dtiles_ion.htmlexample before the second commit:Performance profiling on
3dtiles_ion.htmlexample after the second commit: