-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SBML transcription and translation arcs not using ports #735
Comments
The code that connects arcs with ports, only checked for simple "consumption" and "production" arcs. I also added the option for it to check and connect "transcription" and "translation" arcs of both types to the ports. |
I am not sure if it is related to this issue but when you export an SBML map with "transcription" and "translation" arcs, and then import it again, the arcs are imported as consumption and production arcs. |
Are they imported as simple "consumption" and "production" or "translation consumption" and "translation production"? |
As simple "consumption" and "production". |
I checked with some examples and it seems to be working for me. Can you please check again just to confirm? |
Screen.Recording.2024-07-18.at.05.mp4 |
It only happens when we use a consumption arc of one type(translation or transcription) and the production arc of another type. If both the arcs are of the same type then this does not happen. |
Can we use different types of arc from consumption and production? |
I don't know the rules of SBML but if it doesn't give warning while connecting the nodes, it should be possible. |
@NoorMuhammad1 So, the connections are normal, right? |
What do you mean by connections? |
I mean the map I constructed in the video is correct, right? |
I cannot say for sure, because its using consumption arc of one type and the production arc of another type (translation/transcription). I have not seen any specific rule that prohibits it but I don't know how else to confirm it. |
We need to investigate:
You can revert and check to see if these were happening before your fix to this issue. |
I found the reasons for both:
|
For the second issue, we need to remove ports from here, here and here as well since these code snippets also add ports for species and compartments. |
Ok i will do that. |
(thanks @adrienrougny) Transcription and translation arcs go directly to the process node and not to the ports, unlike normal consumption and production arcs.
The text was updated successfully, but these errors were encountered: