IBX-7911: Replaced usage of magic getters for load subtree code paths #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5 tasks
alongosz
force-pushed
the
ibx-7911-drop-magic-getters
branch
from
d2f0ee2
to
41e4cbe
Compare
alongosz
requested review from
mikadamczyk,
Nattfarinn,
tischsoic,
ViniTou and
a team
konradoboza
approved these changes
May 24, 2024
mikadamczyk
approved these changes
May 24, 2024
Steveb-p
approved these changes
May 24, 2024
alongosz
force-pushed
the
ibx-7911-drop-magic-getters
branch
from
41e4cbe
to
69e2b98
Compare
6 tasks
adamwojs
approved these changes
May 26, 2024
This was referenced May 27, 2024
micszo
approved these changes
Jun 5, 2024
Co-Authored-By: Paweł Niedzielski <Steveb-p@users.noreply.github.com>
alongosz
force-pushed
the
ibx-7911-drop-magic-getters
branch
from
69e2b98
to
ba0073c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6This PR replaces usages of magic getters with strict ones introduced via ibexa/core#347. See the ibexa/core PR for the reasoning behind this change. The scope of the changes is limited to code paths executed when calling
ContentTreeController::loadSubreeActioncontroller.Checklist: