Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8280: Move previewableTranslations info to node extended info endpoint #1262

Merged
merged 6 commits into from
Jun 6, 2024
Merged

IBX-8280: Move previewableTranslations info to node extended info endpoint #1262

merged 6 commits into from
Jun 6, 2024

Conversation

tischsoic
Copy link
Contributor

@tischsoic tischsoic commented May 13, 2024 •
edited by alongosz
Loading

@tischsoic tischsoic force-pushed the IBX-8280-move-previewableTranslations-to-extended-info branch 2 times, most recently from 2aac1e5 to b5aa207 Compare May 13, 2024 06:20
@tischsoic tischsoic requested a review from a team May 13, 2024 09:10
@tischsoic tischsoic force-pushed the IBX-8280-move-previewableTranslations-to-extended-info branch 2 times, most recently from 0007e46 to 9156b78 Compare May 20, 2024 09:17
@tischsoic tischsoic requested review from webhdx and a team May 20, 2024 09:26
webhdx
webhdx approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@webhdx webhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. You are only missing test data that validates XML output for previewableTranslations property.

@webhdx webhdx requested a review from a team May 23, 2024 06:54
@webhdx webhdx requested a review from a team May 23, 2024 10:54
@konradoboza konradoboza requested a review from a team May 23, 2024 11:16
@alongosz alongosz requested a review from a team May 23, 2024 13:52
@konradoboza konradoboza requested a review from a team May 24, 2024 06:18
This was referenced May 27, 2024
Closed
Closed
@tischsoic tischsoic force-pushed the IBX-8280-move-previewableTranslations-to-extended-info branch from bc29202 to 2d0750c Compare June 6, 2024 07:48
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dew326 dew326 merged commit 49dccd1 into 4.6 Jun 6, 2024
22 checks passed
@dew326 dew326 deleted the IBX-8280-move-previewableTranslations-to-extended-info branch June 6, 2024 09:02
@tischsoic
Copy link
Contributor Author

tischsoic commented Jun 6, 2024 •
edited
Loading

Merged up:

@alongosz alongosz mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@webhdx webhdx webhdx approved these changes

@micszo micszo micszo approved these changes

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz Awaiting requested review from alongosz

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tischsoic @mikadamczyk @alongosz @webhdx @micszo @konradoboza @Nattfarinn @ciastektk @dew326 @ViniTou