IBX-4452: Deprecated Policy and Limitation TranslationExtractors #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
reviewed
Dec 6, 2022
Steveb-p
reviewed
Dec 6, 2022
src/lib/Translation/Extractor/LimitationTranslationExtractor.php
Outdated
Show resolved
Hide resolved
mikadamczyk
reviewed
Dec 6, 2022
| @@ -161,861 +161,6 @@ | |||
| <target>All modules / All functions</target> | |||
| <note>key: role.policy.all_modules_all_functions</note> | |||
| </trans-unit> | |||
| <trans-unit id="517e3666a759ee26e02fcc468446ef39b3ae9bf0" resname="role.policy.catalog"> | |||
There was a problem hiding this comment.
those should not be removed if we have no replacement in other packages yet
There was a problem hiding this comment.
I think we will coordinate merging this PR together with other PRs adding translations back in correct packages
There was a problem hiding this comment.
I was thinking that it is leftover because PR is about adding deprecations and has no link to other PRs. Just a friendly reminder to don't merge it as is.
kisztof
force-pushed
the
ibx-4452-deprecate-translation-extractors
branch
from
99a01b8
to
41ff087
Compare
kisztof
force-pushed
the
ibx-4452-deprecate-translation-extractors
branch
from
41ff087
to
35ff8f7
Compare
webhdx
approved these changes
Dec 12, 2022
konradoboza
approved these changes
Dec 12, 2022
adamwojs
approved these changes
Dec 14, 2022
6 tasks
…a new class in ibexa/core
kisztof
force-pushed
the
ibx-4452-deprecate-translation-extractors
branch
from
6adee15
to
2320baf
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
kisztof
requested review from
mikadamczyk,
webhdx,
konradoboza,
adamwojs and
Steveb-p
webhdx
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)Other PR's