Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4452: Added missing translation definitions #49

Merged
merged 1 commit into from
Dec 20, 2022
Merged

IBX-4452: Added missing translation definitions #49

merged 1 commit into from
Dec 20, 2022

Conversation

kisztof
Copy link
Contributor

@kisztof kisztof commented Dec 9, 2022

Question Answer
JIRA issue IBX-4452
Type improvement
Target Ibexa DXP version v4.4
BC breaks no
Doc needed no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/php-dev).

@kisztof kisztof mentioned this pull request Dec 9, 2022
Merged
2 tasks
mikadamczyk
mikadamczyk reviewed Dec 12, 2022
View reviewed changes
Copy link
Contributor

@mikadamczyk mikadamczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for the base branch is failing here

@kisztof kisztof requested a review from a team December 12, 2022 11:09
@kisztof kisztof force-pushed the ibx-4452-deprecate-translation-extractors branch from 7c6ad90 to 459a61d Compare December 20, 2022 08:26
@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikadamczyk mikadamczyk merged commit 1253670 into main Dec 20, 2022
@mikadamczyk mikadamczyk deleted the ibx-4452-deprecate-translation-extractors branch December 20, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@webhdx webhdx webhdx approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@ViniTou ViniTou

Labels
Improvement Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kisztof @mikadamczyk @webhdx @ViniTou @konradoboza @Steveb-p