Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed file visitor for extracting exception messages #232

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Fixed file visitor for extracting exception messages #232

merged 3 commits into from
Aug 24, 2023

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented May 9, 2023 •
edited
Loading

Question Answer
JIRA issue N/A
Type bug
Target Ibexa version v4.5
BC breaks no

Because of this error wrong translation domain was created (messages) during the process of translation extraction in the ibexa/seo package. The correct domain should be repository_exceptions. The file in the seo package could be found here https://github.com/ibexa/seo/blob/main/src/bundle/Resources/translations/repository_exceptions.en.xliff.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@mikadamczyk mikadamczyk requested a review from a team May 9, 2023 13:41
@mikadamczyk mikadamczyk self-assigned this May 9, 2023
alongosz
alongosz reviewed May 10, 2023
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the logic here is quite complicated, maybe we can have unit test coverage to fully understand what's going on?

src/lib/MVC/Symfony/Translation/ExceptionMessageTemplateFileVisitor.php Outdated Show resolved Hide resolved
src/lib/MVC/Symfony/Translation/ExceptionMessageTemplateFileVisitor.php Outdated Show resolved Hide resolved
@mikadamczyk mikadamczyk requested a review from a team May 10, 2023 11:55
@mikadamczyk mikadamczyk requested a review from a team May 10, 2023 12:35
@konradoboza konradoboza requested a review from a team May 10, 2023 12:37
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikadamczyk mikadamczyk changed the base branch from 4.4 to 4.5 August 22, 2023 09:20
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikadamczyk mikadamczyk merged commit e40d311 into 4.5 Aug 24, 2023
22 checks passed
@mikadamczyk mikadamczyk deleted the fixed_translation_visitor branch August 24, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@adamwojs adamwojs

@kisztof kisztof

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mikadamczyk @alongosz @konradoboza @adamwojs @kisztof @Steveb-p @ciastektk